NotFound error on replica periodic tasks

Bug #1923566 reported by Maurice Escher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Low
Maurice Escher

Bug Description

In the periodic tasks 'ShareManager.periodic_share_replica_snapshot_update', 'ShareManager.periodic_share_replica_update' it can happen that the parent share of the replica that is being worked on has already been deleted.

e.g. http://paste.openstack.org/show/804427/

Such errors should be caught and the periodic task should continue with the next element.

Revision history for this message
Maurice Escher (maurice-escher) wrote :
Changed in manila:
status: New → In Progress
Changed in manila:
assignee: nobody → Maurice Escher (maurice-escher)
Changed in manila:
importance: Undecided → Low
milestone: none → xena-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/786012
Committed: https://opendev.org/openstack/manila/commit/29a943fde726f3c667532079eee7297f0579d951
Submitter: "Zuul (22348)"
Branch: master

commit 29a943fde726f3c667532079eee7297f0579d951
Author: Maurice Escher <email address hidden>
Date: Tue Apr 13 09:36:48 2021 +0200

    Reuse _set_instances_share_data for replicas.

    Replicas are just special instances after all, no need for
    duplicate code and missing on improvements like exception handling
    on NotFound error.

    Change-Id: I31fabebc6a60814a4cfc04ae0deb49dcb66cab0f
    Closes-Bug: #1923566

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/manila/+/786904

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/manila/+/786904
Committed: https://opendev.org/openstack/manila/commit/5bd8e46da56a6caa54634bf369ec7a9a335e73e4
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5bd8e46da56a6caa54634bf369ec7a9a335e73e4
Author: Maurice Escher <email address hidden>
Date: Tue Apr 13 09:36:48 2021 +0200

    Reuse _set_instances_share_data for replicas.

    Replicas are just special instances after all, no need for
    duplicate code and missing on improvements like exception handling
    on NotFound error.

    Change-Id: I31fabebc6a60814a4cfc04ae0deb49dcb66cab0f
    Closes-Bug: #1923566
    (cherry picked from commit 29a943fde726f3c667532079eee7297f0579d951)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/manila/+/792664

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/manila/+/792664
Committed: https://opendev.org/openstack/manila/commit/1ae67eb0d6dd2b2f1a3a5b38736514ed8a0a20b2
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 1ae67eb0d6dd2b2f1a3a5b38736514ed8a0a20b2
Author: Maurice Escher <email address hidden>
Date: Tue Apr 13 09:36:48 2021 +0200

    Reuse _set_instances_share_data for replicas.

    Replicas are just special instances after all, no need for
    duplicate code and missing on improvements like exception handling
    on NotFound error.

    Change-Id: I31fabebc6a60814a4cfc04ae0deb49dcb66cab0f
    Closes-Bug: #1923566
    (cherry picked from commit 29a943fde726f3c667532079eee7297f0579d951)
    (cherry picked from commit 5bd8e46da56a6caa54634bf369ec7a9a335e73e4)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/manila/+/792772

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/manila/+/792772
Committed: https://opendev.org/openstack/manila/commit/6707ca7bcbed9485fa73c6d0de039438966ac5cc
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 6707ca7bcbed9485fa73c6d0de039438966ac5cc
Author: Maurice Escher <email address hidden>
Date: Tue Apr 13 09:36:48 2021 +0200

    Reuse _set_instances_share_data for replicas.

    Replicas are just special instances after all, no need for
    duplicate code and missing on improvements like exception handling
    on NotFound error.

    Change-Id: I31fabebc6a60814a4cfc04ae0deb49dcb66cab0f
    Closes-Bug: #1923566
    (cherry picked from commit 29a943fde726f3c667532079eee7297f0579d951)
    (cherry picked from commit 5bd8e46da56a6caa54634bf369ec7a9a335e73e4)
    (cherry picked from commit 1ae67eb0d6dd2b2f1a3a5b38736514ed8a0a20b2)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/manila/+/794056

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/train)

Reviewed: https://review.opendev.org/c/openstack/manila/+/794056
Committed: https://opendev.org/openstack/manila/commit/cf9a6eb6c76cee7a3c4d209fe87e077e026daee2
Submitter: "Zuul (22348)"
Branch: stable/train

commit cf9a6eb6c76cee7a3c4d209fe87e077e026daee2
Author: Maurice Escher <email address hidden>
Date: Tue Apr 13 09:36:48 2021 +0200

    Reuse _set_instances_share_data for replicas.

    Replicas are just special instances after all, no need for
    duplicate code and missing on improvements like exception handling
    on NotFound error.

    Change-Id: I31fabebc6a60814a4cfc04ae0deb49dcb66cab0f
    Closes-Bug: #1923566
    (cherry picked from commit 29a943fde726f3c667532079eee7297f0579d951)
    (cherry picked from commit 5bd8e46da56a6caa54634bf369ec7a9a335e73e4)
    (cherry picked from commit 1ae67eb0d6dd2b2f1a3a5b38736514ed8a0a20b2)
    (cherry picked from commit 6707ca7bcbed9485fa73c6d0de039438966ac5cc)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 10.1.0

This issue was fixed in the openstack/manila 10.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers