Netapp non-disruptive migration of cifs shares export location broken

[Maurice Escher]

Hi,

I want to non-disruptively migrate my CIFS shares in my Netapp back end from pool A to B.
But it fails in generating the export locations on migration complete.

The error I get is 'NetApp API failed. Reason - 13001:The specified path "/share_<new-si-uuid>" does not exist in the namespace belonging to Vserver "<vserver-name>".' from cifs-share-create API call

I think there need to be two fixes:
1. https://opendev.org/openstack/manila/src/commit/50401393c74f65aee73db82f22eb531898bc68cf/manila/share/drivers/netapp/dataontap/protocols/cifs_cmode.py#L35-L36

create_cifs_share should not be called in that case, because the cifs share is already present.

2. https://opendev.org/openstack/manila/src/commit/50401393c74f65aee73db82f22eb531898bc68cf/manila/share/drivers/netapp/dataontap/protocols/cifs_cmode.py#L50-L51

the return should not use the share name, which is a thing that changes on migration, because a new share instance is created, but rather look at the junction path like with NFS protocol (https://opendev.org/openstack/manila/src/commit/50401393c74f65aee73db82f22eb531898bc68cf/manila/share/drivers/netapp/dataontap/protocols/nfs_cmode.py#L53) , I suppose.

Best regards,
Maurice

[Goutham Pacha Ravi (gouthamr)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2021/manila.2021-05-13-15.00.log.html#l-113

[Goutham Pacha Ravi (gouthamr)]

Caique, we're closing on xena-RC1 soon.

i'm moving this bug to Yoga-1; please let me know if that timeline is inaccurate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/858140

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/858140
Committed: https://opendev.org/openstack/manila/commit/9ddddeeea3123c4af638e54c54a05deb3d59672a
Submitter: "Zuul (22348)"
Branch: master

commit 9ddddeeea3123c4af638e54c54a05deb3d59672a
Author: CaiqueMello <email address hidden>
Date: Fri Sep 16 14:01:17 2022 +0000

    [NetApp] Fix non-disruptive migration cifs shares

    Migrate non-disruptive cifs share from different pools change the
    export location. When the non-disruptive migration complete
    process is started a new share and export location is created. As
    result, Manila finds a conflict between the old export location and
    the new one.

    This patch add a condition to skip export location creation when
    a CIFS migration is in progress, also change the way that the export
    location is created. Instead of create the export path with share
    name, the new one is taken from the backend. The fix is only for
    ZAPI API calls.

    Change-Id: I1bb888a0b644f0b071816d275d464c4dd27125a7
    Co-authored-by: Lucas Oliveira <email address hidden>
    Closes-bug: #1920937

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/manila/+/880593

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/manila/+/881323

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/881324

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/manila/+/881325

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 17.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 16.1.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/881324
Reason: stable/yoga branch of openstack/manila is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/yoga if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: unmaintained/yoga
Review: https://review.opendev.org/c/openstack/manila/+/909548

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/xena
Review: https://review.opendev.org/c/openstack/manila/+/881325
Reason: stable/xena branch of openstack/manila is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/xena if you want to further work on this patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: unmaintained/xena
Review: https://review.opendev.org/c/openstack/manila/+/911617

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/zed
Review: https://review.opendev.org/c/openstack/manila/+/881323
Reason: stable/zed branch of openstack/manila is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/zed if you want to further work on this patch.