Project users can get other project replicas by UUID

Bug #1918341 reported by Goutham Pacha Ravi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
In Progress
Medium
Jiabo Cheng

Bug Description

Description
===========
This is a RBAC issue where as any authenticated user, I can retrieve a replica and its export locations even if it is in a project I'm not part of. I will however need to know the ID of the replica to do this. No manila API currently discloses this ID, and it would have to be guessed by users that have only the API to work with. Guessing UUIDs is considered impractical.

Steps to reproduce
==================

A chronological list of steps which will help reproduce the issue you hit:
* As user X in project Y, create a share and a replica and note replica ID
* As user A in project B, attempt to retrieve replica information and export location information:

 GET share-replicas/${share_replica_id}/export-locations
 GET share-replicas/${share_replica_id}/export-locations/${export_location_id}
 GET share-replicas/${share_replica_id}

Expected result
===============
HTTP 404 if replica is inaccessible to me

Actual result
=============
HTTP 200 with replica details

Environment
===========
1. Manila main (Wallaby)

Changed in manila:
importance: Undecided → Medium
milestone: none → wallaby-rc1
tags: added: rbac
tags: added: backport-potential rocky-backport-potential stein-backport-potential train-backport-potential ussuri-backport-potential victoria-backport-potential
tags: added: wallaby-rc-bugsquash
Changed in manila:
milestone: wallaby-rc1 → xena-1
assignee: nobody → Goutham Pacha Ravi (gouthamr)
tags: removed: wallaby-rc-bugsquash
tags: added: wallaby-backport-potential
Changed in manila:
milestone: xena-1 → xena-2
Changed in manila:
status: New → Confirmed
Changed in manila:
milestone: xena-2 → xena-3
Changed in manila:
milestone: xena-3 → yoga-1
Changed in manila:
milestone: yoga-1 → yoga-2
Jiabo Cheng (cheng-jiab)
Changed in manila:
assignee: Goutham Pacha Ravi (gouthamr) → Jiabo Cheng (cheng-jiab)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/820468

Changed in manila:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by "Jiabo Cheng <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/manila/+/820468
Reason: Duplicated bug with Bug #1922243

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.