Share migration with NetApp fails compatibility check due to encryption

[Goutham Pacha Ravi]

Description
===========
I have an ONTAP 9.0 storage system and wanted to move my manila share across aggregates on it. This should be possible with driver assisted share migration as documented here: https://netapp-openstack-dev.github.io/openstack-docs/train/manila/examples/openstack_command_line/section_manila-cli.html#migrating-manila-shares

However, this fails the migration compatibility check and digging into the manila-share logs, i see the cause of the error is an unexpected parameter in the volume-move API: http://paste.openstack.org/show/802493/

Steps to reproduce
==================

1) Setup manila DHSS=False backed by NetApp ONTAP 9.0 with at least two data aggregates that will show up as manila storage pools
2) Create a share, note the pool it ends up in
3) Migrate the share to the second pool with parameters: --preserve-metadata True --preserve-snapshots True --writable True --nondisruptive True

Expected result
===============
The driver performs volume move to move the share to the desired storage pool

Actual result
=============
Migration compatibility check fails, the volume move dry run errors with "NaApiError: NetApp API failed. Reason - 13115:Extra input: encrypt-destination"

Environment
===========
1. Manila stable/train
2. ONTAP 9.0 (ontapi_1_100)

[Douglas Viroel (dviroel)]

Confirmed, the 'encrypt-destination' parameter, used in 'volume-move-start' operation, is only available for Ontapi >= 1.110 (ONTAP >= 9.1)

[Vida Haririan (vhariria)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2021/manila.2021-02-11-15.00.log.html

[Goutham Pacha Ravi (gouthamr)]

Carlos, we're closing on xena-RC1 soon.

i'm moving this bug to Yoga-1; please let me know if that timeline is inaccurate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/820891

[Fábio Oliveira (fabiooliveira1)]

FYI: This is the link from OnTap docs 9.0 (https://docs.netapp.com/ontap-9/index.jsp?topic=%2Fcom.netapp.doc.dot-cm-cmpr-900%2Fvolume__move__start.html) and 9.1 (https://docs.netapp.com/ontap-9/index.jsp?topic=%2Fcom.netapp.doc.dot-cm-cmpr-910%2Fvolume__move__start.html)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/820891
Committed: https://opendev.org/openstack/manila/commit/9417ece45629d4103d2b37a593dfbcc7e774362c
Submitter: "Zuul (22348)"
Branch: master

commit 9417ece45629d4103d2b37a593dfbcc7e774362c
Author: Fabio Oliveira <email address hidden>
Date: Tue Dec 7 11:13:29 2021 -0300

    NetApp OnTap: Fix compatibility check for share migrate

    The issue happens when the parameter 'encrypt-destination' is sent to
    OnTap devices with version lower than 9.0 or OnTapi lower then 1.110.

    This patch adds a condition to check these versions and ignore the flag
    addition if needed on '_send_volume_move_request'.

    Closes-Bug: 1915237
    Change-Id: Id9faa4f73996cb7467b7361d0406c980f06905c2

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 14.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/manila/+/847161

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/manila/+/855234

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/847161
Committed: https://opendev.org/openstack/manila/commit/27d79965f79fea4b34809fcd449f007ed6cc5ec5
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 27d79965f79fea4b34809fcd449f007ed6cc5ec5
Author: Fabio Oliveira <email address hidden>
Date: Tue Dec 7 11:13:29 2021 -0300

    NetApp OnTap: Fix compatibility check for share migrate

    The issue happens when the parameter 'encrypt-destination' is sent to
    OnTap devices with version lower than 9.0 or OnTapi lower then 1.110.

    This patch adds a condition to check these versions and ignore the flag
    addition if needed on '_send_volume_move_request'.

    Closes-Bug: 1915237
    Change-Id: Id9faa4f73996cb7467b7361d0406c980f06905c2
    (cherry picked from commit 9417ece45629d4103d2b37a593dfbcc7e774362c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/855234
Committed: https://opendev.org/openstack/manila/commit/ee7ede8a363044c20c0145caef438aa9ca8743f9
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ee7ede8a363044c20c0145caef438aa9ca8743f9
Author: Fabio Oliveira <email address hidden>
Date: Tue Dec 7 11:13:29 2021 -0300

    NetApp OnTap: Fix compatibility check for share migrate

    The issue happens when the parameter 'encrypt-destination' is sent to
    OnTap devices with version lower than 9.0 or OnTapi lower then 1.110.

    This patch adds a condition to check these versions and ignore the flag
    addition if needed on '_send_volume_move_request'.

    Closes-Bug: 1915237
    Change-Id: Id9faa4f73996cb7467b7361d0406c980f06905c2
    (cherry picked from commit 9417ece45629d4103d2b37a593dfbcc7e774362c)
    (cherry picked from commit 27d79965f79fea4b34809fcd449f007ed6cc5ec5)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 13.0.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila wallaby-eom release.