manila_tempest_plugin is missing the get_default_share_type function is the internal client

[Victoria Martinez de la Cruz]

An internal shares client is being used to perform calls to the manila server [0] from the manila tempest tests. This client is missing a function to call to the list default share types endpoint [1]. We need this function to get the default share type when running scenario tests.

Currently we are using the get share types endpoint [2]. This is wrong, since the get share types endpoints expect an ID, not a name. But, luckily, in most cases (since we call the default share type "default" in our CI) this was working.

In deployments in which the default share type is named different to "default", the scenario tests are broken (e.g. when deploying manila with cephfs backends, the default share types are called cephfsnative and cephfsnfs respectively)

[0] https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/services/share/json/shares_client.py
[1] https://docs.openstack.org/api-ref/shared-file-system/?expanded=show-share-type-detail-detail,list-default-share-types-detail#list-default-share-types
[2] https://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/tests/scenario/manager_share.py#L454-L456

[Goutham Pacha Ravi (gouthamr)]

Fix released: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/764392

[Vida Haririan (vhariria)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-12-10-15.02.log.html
Fix was merged

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila-tempest-plugin stein-last release.