netapp kerberos-realm-create api changed

[Maurice Escher]

Hi,

I encountered a bug in the netapp dataontap driver.

The NetApp "Reference Manual for ONTAP 9.7" states:

"In Data ONTAP 8.2.x and prior versions, Kerberos realms were owned by Cserver and were accessible
only from Admin Vserver LIFs using the input 'config-name'. The 'vserver' input was not required.
Starting from Data ONTAP 8.3.0, Kerberos realms are owned by data Vservers and are accessible from
both Admin and data Vserver LIFs. The 'config-name' input can no longer be used as a key. The 'realm'
input must be used instead. The 'vserver' input is required."

Which leads to the following error in later versions if I try to create a kerberos CIFS share:
'NetAppException
Failed to create Kerberos realm. Vserver API missing vserver parameter.' raised in manila/share/drivers/netapp/dataontap/client/client_cmode.py in create_kerberos_realm

This needs to be adjusted for ONTAP >= 8.3, please.

I.e.
- needs to be called like vserver_client.create_kerberos_realm(security_service)
- config-name parameter removed
- for backwards compatability keep old version for older apis?
- other unforeseeable issues ..?

BR,
Maurice

[Vida Haririan (vhariria)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-11-05-15.01.log.html

[Vida Haririan (vhariria)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-12-03-15.00.log.html

[Goutham Pacha Ravi (gouthamr)]

Fix proposed here: https://review.opendev.org/c/openstack/manila/+/772177

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 12.0.0.0rc1 release candidate.