NetApp driver is not applying the access rules for the promoted replica using CIFS

[Felipe Rodrigues]

Description
===========
Using NetApp driver, the promote of a share replica created from a CIFS share is not applying the access rules.

Steps to reproduce
==================

* Create a share that can be replicated
* Allow access for a given user
* Create a share replica
* Promote the share replica
* Try to mount the share

Expected result
===============

The access rules should be applied in the promoted replica.

Actual result
=============

The access rules are not being applied in the new active replica. If you want to mount the share, you will need to deny the current access and allow it again.

Environment
===========
1. Devstack deployed on Ubuntu 18.04

2. Manila using the master branch (microversion 2.55)

3. NetApp DHSS=True/False backend using the standalone network plugin

[Vida Haririan (vhariria)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-09-24-15.00.log.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/755934

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/755934
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0c4d1e339801bb9d346dfa5a29af2ab76517bbd7
Submitter: Zuul
Branch: master

commit 0c4d1e339801bb9d346dfa5a29af2ab76517bbd7
Author: Felipe Rodrigues <email address hidden>
Date: Thu Sep 24 12:22:20 2020 +0000

    [NetApp] Fix access rules for CIFS promoted replica

    This patch fixes the access rules for NetApp promote replica when
    using CIFS protocol. When promoting a replica, the NetApp ONTAP
    driver updates the access rules for the promoted CIFS share entity
    before actually creating it, failing on having those rules
    applied.

    The bug is fixed by switching the order of updating the access
    and creating the promoted CIFS share entity.

    Change-Id: I60e4057dc962d96cff57dea88587a28c2043b499
    Closes-Bug: #1896949

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/758106

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/758106
Committed: https://opendev.org/openstack/manila/commit/c857b94e8a8aae1f471ebbde8b49beaad41ef431
Submitter: Zuul
Branch: stable/victoria

commit c857b94e8a8aae1f471ebbde8b49beaad41ef431
Author: Felipe Rodrigues <email address hidden>
Date: Thu Sep 24 12:22:20 2020 +0000

    [NetApp] Fix access rules for CIFS promoted replica

    This patch fixes the access rules for NetApp promote replica when
    using CIFS protocol. When promoting a replica, the NetApp ONTAP
    driver updates the access rules for the promoted CIFS share entity
    before actually creating it, failing on having those rules
    applied.

    The bug is fixed by switching the order of updating the access
    and creating the promoted CIFS share entity.

    Change-Id: I60e4057dc962d96cff57dea88587a28c2043b499
    Closes-Bug: #1896949
    (cherry picked from commit 0c4d1e339801bb9d346dfa5a29af2ab76517bbd7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 11.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 12.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/772728
Committed: https://opendev.org/openstack/manila/commit/65c9f6f4a21cc9689e6ad1d02a1e641cdb51f1b5
Submitter: "Zuul (22348)"
Branch: stable/train

commit 65c9f6f4a21cc9689e6ad1d02a1e641cdb51f1b5
Author: Felipe Rodrigues <email address hidden>
Date: Thu Sep 24 12:22:20 2020 +0000

    [NetApp] Fix access rules for CIFS promoted replica

    This patch fixes the access rules for NetApp promote replica when
    using CIFS protocol. When promoting a replica, the NetApp ONTAP
    driver updates the access rules for the promoted CIFS share entity
    before actually creating it, failing on having those rules
    applied.

    The bug is fixed by switching the order of updating the access
    and creating the promoted CIFS share entity.

    Change-Id: I60e4057dc962d96cff57dea88587a28c2043b499
    Closes-Bug: #1896949
    (cherry picked from commit 0c4d1e339801bb9d346dfa5a29af2ab76517bbd7)
    (cherry picked from commit c857b94e8a8aae1f471ebbde8b49beaad41ef431)
    (cherry picked from commit 460f44704df3303e092de3e9781224fdbbe8502d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 10.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila train-eol release.