After the glusterfs driver deletes the share, the client can still read and write the share

Bug #1886010 reported by Lin PeiWen on 2020-07-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Medium
Lin PeiWen

Bug Description

Description
===========

Steps to reproduce
==================

* Deploying Manila using glusterfs driver
* Create a shared instance, write some unimportant data, and then delete the shared instance

Expected result
===============

Erase data in shared instance, disconnect mount point

Actual result
=============

The data in the shared instance is erased, the client mount point is not disconnected, and new data can still be read and written

Environment
===========

1.OpenStack rocky

2.Which storage backend did you use? GlusterFS driver

3.glusterfs_nfs_server_type = Gluster

4.glusterfs_share_layout = layout_volume.GlusterfsVolumeMappedLayout

Lin PeiWen (linpeiwen) on 2020-07-02
Changed in manila:
assignee: nobody → Lin PeiWen (linpeiwen)
Changed in manila:
status: New → In Progress
Vida Haririan (vhariria) on 2020-08-20
Changed in manila:
importance: Undecided → Medium
milestone: none → victoria-3
Changed in manila:
assignee: Lin PeiWen (linpeiwen) → Goutham Pacha Ravi (gouthamr)
Changed in manila:
assignee: Goutham Pacha Ravi (gouthamr) → Lin PeiWen (linpeiwen)

Reviewed: https://review.opendev.org/738997
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=9d44ba0b6a2d20be6158ff667ff3b81de31f5cad
Submitter: Zuul
Branch: master

commit 9d44ba0b6a2d20be6158ff667ff3b81de31f5cad
Author: linpeiwen <email address hidden>
Date: Thu Jul 2 04:48:17 2020 -0400

    [Glusterfs] Fix delete share, mount point not disconnected

    When we delete the shared instance, in addition to erasing the data
    in the share, we should disconnect the client's mount point to
    prevent the data from being written in.

    Closes-Bug: #1886010
    Change-Id: I7a334fb895669cc807a288e6aefe62154a89a7e4

Changed in manila:
status: In Progress → Fix Released

Change abandoned by Lin PeiWen (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/750180
Reason: This branch is cherry picking from the master, so give up and cherry pick from ussuri again, thanks to Sean McGinnis’ reminder

Change abandoned by Lin PeiWen (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/750182
Reason: This branch is cherry picking from the master, so give up and cherry pick from train again, thanks to Sean McGinnis’ reminder

Change abandoned by Lin PeiWen (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/750183
Reason: This branch is cherry picking from the master, so give up and cherry pick from stein again, thanks to Sean McGinnis’ reminder

Reviewed: https://review.opendev.org/750179
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4f2e400a6bcbcb79103354a76211455f9e7c605a
Submitter: Zuul
Branch: stable/ussuri

commit 4f2e400a6bcbcb79103354a76211455f9e7c605a
Author: linpeiwen <email address hidden>
Date: Thu Jul 2 04:48:17 2020 -0400

    [Glusterfs] Fix delete share, mount point not disconnected

    When we delete the shared instance, in addition to erasing the data
    in the share, we should disconnect the client's mount point to
    prevent the data from being written in.

    Closes-Bug: #1886010
    Change-Id: I7a334fb895669cc807a288e6aefe62154a89a7e4
    (cherry picked from commit 9d44ba0b6a2d20be6158ff667ff3b81de31f5cad)

tags: added: in-stable-ussuri

Reviewed: https://review.opendev.org/750180
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=d9e6743ba5b45d75212fd9a247d3f2ec60958f04
Submitter: Zuul
Branch: stable/train

commit d9e6743ba5b45d75212fd9a247d3f2ec60958f04
Author: linpeiwen <email address hidden>
Date: Thu Jul 2 04:48:17 2020 -0400

    [Glusterfs] Fix delete share, mount point not disconnected

    When we delete the shared instance, in addition to erasing the data
    in the share, we should disconnect the client's mount point to
    prevent the data from being written in.

    Closes-Bug: #1886010
    Change-Id: I7a334fb895669cc807a288e6aefe62154a89a7e4
    (cherry picked from commit 9d44ba0b6a2d20be6158ff667ff3b81de31f5cad)
    (cherry picked from commit 4f2e400a6bcbcb79103354a76211455f9e7c605a)

tags: added: in-stable-train

Reviewed: https://review.opendev.org/750182
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4e75f14c76c17d46b551f46c6a9d1f6d14adf7c0
Submitter: Zuul
Branch: stable/stein

commit 4e75f14c76c17d46b551f46c6a9d1f6d14adf7c0
Author: linpeiwen <email address hidden>
Date: Thu Jul 2 04:48:17 2020 -0400

    [Glusterfs] Fix delete share, mount point not disconnected

    When we delete the shared instance, in addition to erasing the data
    in the share, we should disconnect the client's mount point to
    prevent the data from being written in.

    Closes-Bug: #1886010
    Change-Id: I7a334fb895669cc807a288e6aefe62154a89a7e4
    (cherry picked from commit 9d44ba0b6a2d20be6158ff667ff3b81de31f5cad)
    (cherry picked from commit 4f2e400a6bcbcb79103354a76211455f9e7c605a)
    (cherry picked from commit d9e6743ba5b45d75212fd9a247d3f2ec60958f04)

tags: added: in-stable-stein

Reviewed: https://review.opendev.org/750183
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0ac95862be135b7bbb2904a977d463abe301c08a
Submitter: Zuul
Branch: stable/rocky

commit 0ac95862be135b7bbb2904a977d463abe301c08a
Author: linpeiwen <email address hidden>
Date: Thu Jul 2 04:48:17 2020 -0400

    [Glusterfs] Fix delete share, mount point not disconnected

    When we delete the shared instance, in addition to erasing the data
    in the share, we should disconnect the client's mount point to
    prevent the data from being written in.

    Closes-Bug: #1886010
    Change-Id: I7a334fb895669cc807a288e6aefe62154a89a7e4
    (cherry picked from commit 9d44ba0b6a2d20be6158ff667ff3b81de31f5cad)
    (cherry picked from commit 4f2e400a6bcbcb79103354a76211455f9e7c605a)
    (cherry picked from commit d9e6743ba5b45d75212fd9a247d3f2ec60958f04)
    (cherry picked from commit 4e75f14c76c17d46b551f46c6a9d1f6d14adf7c0)

tags: added: in-stable-rocky

Reviewed: https://review.opendev.org/753425
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=7247032a80dc5822f401a28074bb6022b534f3df
Submitter: Zuul
Branch: stable/queens

commit 7247032a80dc5822f401a28074bb6022b534f3df
Author: linpeiwen <email address hidden>
Date: Thu Jul 2 04:48:17 2020 -0400

    [Glusterfs] Fix delete share, mount point not disconnected

    When we delete the shared instance, in addition to erasing the data
    in the share, we should disconnect the client's mount point to
    prevent the data from being written in.

    Closes-Bug: #1886010
    Change-Id: I7a334fb895669cc807a288e6aefe62154a89a7e4
    (cherry picked from commit 9d44ba0b6a2d20be6158ff667ff3b81de31f5cad)
    (cherry picked from commit 4f2e400a6bcbcb79103354a76211455f9e7c605a)
    (cherry picked from commit d9e6743ba5b45d75212fd9a247d3f2ec60958f04)
    (cherry picked from commit 4e75f14c76c17d46b551f46c6a9d1f6d14adf7c0)
    (cherry picked from commit 0ac95862be135b7bbb2904a977d463abe301c08a)

tags: added: in-stable-queens
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers