HTTPS is not working with python3.7 NetAppDriver

Bug #1878993 reported by Felipe Rodrigues
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Felipe Rodrigues

Bug Description

Steps to reproduce
==================

Firstly, deploy the manila to use python3.7.

Then, configure the manila.conf to use a Netapp backend with https.

Finally, restarting the manila share service the backend does not
get up!

The same bug is reported by other vendors: https://bugs.launchpad.net/manila/+bug/1833160

Expected result
===============
The backend should be up state

Actual result
=============
The backend is down state

Environment
===========
1. Version: Train

2. Backend: Netapp

3. Python3.7

Logs & Configs
==============

The errorlog:

Apr 24 14:33:40 51-felipe-https manila-share[2776]: ERROR manila.share.manager server_hostname=server_hostname)
Apr 24 14:33:40 51-felipe-https manila-share[2776]: ERROR manila.share.manager File "/usr/local/lib/python3.7/dist-packages/eventlet/green/ssl.py", line 437, in wrap_socket
Apr 24 14:33:40 51-felipe-https manila-share[2776]: ERROR manila.share.manager return GreenSSLSocket(sock, *a, _context=self, **kw)
Apr 24 14:33:40 51-felipe-https manila-share[2776]: ERROR manila.share.manager File "/usr/local/lib/python3.7/dist-packages/eventlet/green/ssl.py", line 76, in new
Apr 24 14:33:40 51-felipe-https manila-share[2776]: ERROR manila.share.manager *args, **kw
Apr 24 14:33:40 51-felipe-https manila-share[2776]: ERROR manila.share.manager TypeError: wrap_socket() got an unexpected keyword argument '_context'

Douglas Viroel (dviroel)
tags: added: netapp
Changed in manila:
assignee: nobody → Felipe Rodrigues (felipefutty)
Douglas Viroel (dviroel)
Changed in manila:
status: New → Triaged
importance: Undecided → Medium
importance: Medium → Low
milestone: none → victoria-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/731359

Changed in manila:
status: Triaged → In Progress
Changed in manila:
milestone: victoria-1 → victoria-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/731359
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=29622725e411402b835e3e45328a9e695f75ea78
Submitter: Zuul
Branch: master

commit 29622725e411402b835e3e45328a9e695f75ea78
Author: Felipe Rodrigues <email address hidden>
Date: Wed May 6 23:54:59 2020 +0000

    [NetApp] Fix HTTPS connection for python 3.7

    With python3.7, the eventlet is breaking the ssl.py, so the https
    is not working. This patch fixes it by changing the request library
    (urllib by requests), the new library can be built over the
    pyopenssl.py instead of ssl.py.

    Closes-Bug: #1878993
    Change-Id: I9c0b1f332ead25634f3dc3aebfdc8b51dfbc4178

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/737756

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/ussuri)

Reviewed: https://review.opendev.org/737756
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=2dbdace6616d34bfb43c72905dda04c91bcf1dc6
Submitter: Zuul
Branch: stable/ussuri

commit 2dbdace6616d34bfb43c72905dda04c91bcf1dc6
Author: Felipe Rodrigues <email address hidden>
Date: Wed May 6 23:54:59 2020 +0000

    [NetApp] Fix HTTPS connection for python 3.7

    With python3.7, the eventlet is breaking the ssl.py, so the https
    is not working. This patch fixes it by changing the request library
    (urllib by requests), the new library can be built over the
    pyopenssl.py instead of ssl.py.

    Closes-Bug: #1878993
    Change-Id: I9c0b1f332ead25634f3dc3aebfdc8b51dfbc4178
    (cherry picked from commit 29622725e411402b835e3e45328a9e695f75ea78)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/754474

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/train)

Reviewed: https://review.opendev.org/754474
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=02251481e11d0a7fdcc128dc694a26d3372a6bdb
Submitter: Zuul
Branch: stable/train

commit 02251481e11d0a7fdcc128dc694a26d3372a6bdb
Author: Felipe Rodrigues <email address hidden>
Date: Wed May 6 23:54:59 2020 +0000

    [NetApp] Fix HTTPS connection for python 3.7

    With python3.7, the eventlet is breaking the ssl.py, so the https
    is not working. This patch fixes it by changing the request library
    (urllib by requests), the new library can be built over the
    pyopenssl.py instead of ssl.py.

    Closes-Bug: #1878993
    Change-Id: I9c0b1f332ead25634f3dc3aebfdc8b51dfbc4178
    (cherry picked from commit 29622725e411402b835e3e45328a9e695f75ea78)
    (cherry picked from commit 2dbdace6616d34bfb43c72905dda04c91bcf1dc6)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 9.1.5

This issue was fixed in the openstack/manila 9.1.5 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers