CI: manila-tempest-dsvm-postgres-container job is failing

[Goutham Pacha Ravi]

Description
===========
manila-tempest-dsvm-postgres-container job started failing ~May 4th 2020, on the master branch of manila and manila-tempest-plugin.

This is a legacy Zuulv3 job that sets up manila with the Container driver (creating filesystems on the host and exporting them via CIFS from the Samba server running inside a docker container).

Steps to reproduce
==================

To locally reproduce the issue, create a devstack with the container driver with the master branch of manila and create a share on a share network. Check the share service logs, share server provisioning fails, which leads to the share creation failing.

The server creation fails while executing:

    sudo manila-rootwrap /etc/manila/rootwrap.conf brctl show docker0

on the host running the manila-share service

Expected result
===============
share creation succeeds

Actual result
=============
share creation fails

Environment
===========
1. Manila master branch (Victoria development cycle) on Ubuntu 18.04 LTS

2. Which storage backend did you use?
   Container driver

3. Which networking type did you use?
   Neutron with OpenVSwitch

Logs & Configs
==============

Error in manila's share manager service logs: http://paste.openstack.org/show/793082/

Full log file is attached to the bug report

https://zuul.opendev.org/t/openstack/builds?job_name=manila-tempest-dsvm-postgres-container&project=openstack%2Fmanila#

[Goutham Pacha Ravi (gouthamr)]

We were relying on Devstack installing the package "bridge_utils". This was removed from DevStack via: https://review.opendev.org/#/c/724443/

[Goutham Pacha Ravi (gouthamr)]

Neutron replaced the use of brctl with ip commands in this review: https://review.opendev.org/#/c/617836/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/725407

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/725407
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3b509399e3c4c95f0cc6cf1b0e2fc80fe315b9ba
Submitter: Zuul
Branch: master

commit 3b509399e3c4c95f0cc6cf1b0e2fc80fe315b9ba
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon May 4 14:48:52 2020 -0700

    [ci][devstack] Install bridge-utils for Container driver

    Devstack no longer installs this package after [1]. The driver
    needs to replace the use of brctl to completely remove this
    package from our test environments.

    [1] https://review.opendev.org/724443/
    Partial-Bug: #1876820

    Change-Id: Id6094827341bf6ef8856cd4e7af11b36e9afb560
    Signed-off-by: Goutham Pacha Ravi <email address hidden>

[Vida Haririan (vhariria)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-05-07-15.02.log.html

[Goutham Pacha Ravi (gouthamr)]

A workaround has been merged to fix the CI job. Please use https://bugs.launchpad.net/manila/+bug/1877410 to track changes to the driver to get rid of the use of brctl.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/manila/+/793571

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/793571
Committed: https://opendev.org/openstack/manila/commit/a853b0cc91ccad5581cc19bc851cf8e16c04a031
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit a853b0cc91ccad5581cc19bc851cf8e16c04a031
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon May 4 14:48:52 2020 -0700

    [ci][devstack] Install bridge-utils for Container driver

    Devstack no longer installs this package after [1]. The driver
    needs to replace the use of brctl to completely remove this
    package from our test environments.

    [1] https://review.opendev.org/724443/
    Partial-Bug: #1876820

    Depends-On: I6c7db2286d544ff8156926e07efd57628cfdc9ff
    Change-Id: Id6094827341bf6ef8856cd4e7af11b36e9afb560
    Signed-off-by: Goutham Pacha Ravi <email address hidden>
    (cherry picked from commit 3b509399e3c4c95f0cc6cf1b0e2fc80fe315b9ba)