With Manila operating in `driver_handles_share_servers` true, the NetApp driver fails to create a intra-cluster vserver peer relationship. This scenario happens when source and destination lies on the same cluster but in different vservers (share-servers). The vserver peering in this scenario doesn't need to be accepted but the NetApp driver triggers the 'accept-vserver-peer' operation.
It was observed in the following scenario, but may happen with different sequence of operations:
1. Configure three NetApp backends in `driver_handles_share_servers` true mode. Two backends on availability zone 'B' should belong to the same cluster, but with different aggregates;
2. Create a share with replication enabled on availability zone 'A';
3. Create two replicas on availability zone 'B';
4. Promote one of the replicas.
When trying to creating new relationships between replicas and the new active instance, the vserver peer operation fails while triggering a 'accept-vserver-peer' operation.
Error that appears in the log:
manila-share[26380]: DEBUG manila.share.drivers.netapp.dataontap.client.api [None req-2623c83b-3dc1-4c03-bbcc-02c942cd01e4 None None] Response: b'<results xmlns="http://www.netapp.com/filer/admin" reason="Invalid operation on intra cluster Vserver peer relationship." status="failed" errno="18180"/>\n' {{(pid=27094) invoke_elem /opt/stack/new/manila/manila/share/drivers/netapp/dataontap/client/api.py:263}}
manila-share[26380]: ERROR manila.share.drivers.netapp.dataontap.cluster_mode.lib_base [None req-2623c83b-3dc1-4c03-bbcc-02c942cd01e4 None None] Failed to change replica (15520da9-b981-43ba-8682-5284e0866191) to a SnapMirror destination.: manila.share.drivers.netapp.dataontap.client.api.NaApiError: NetApp API failed. Reason - 18180:Invalid operation on intra cluster Vserver peer relationship.
Fix proposed to branch: master
Review: https:/