update provisioned_capacity_gb in consume from share

Bug #1872873 reported by zhangqing
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
zhangqing

Bug Description

when scheduler choose backend with capacity filter, it uses host_state.provisioned_capacity_gb to get provisioned_ratio.

when creating shares in sequence, if the last share has choosen one host, then the next share caculate the same host's provisioned_ratio should use the sum of host_state.provisioned_capacity_gb and the size of last share. Otherwise in extremely situation, the backend will be over max_over_subscription_ratio.

so once share choose one host, then the host's provisioned_capacity_gb shoud update in the method consume from share.

Changed in manila:
assignee: nobody → zhangqing (zhang-qing)
status: New → In Progress
Vida Haririan (vhariria)
Changed in manila:
milestone: none → ussuri-rc1
importance: Undecided → Low
Revision history for this message
Vida Haririan (vhariria) wrote :
Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/#/c/716820/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/716820
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4b471012de5613cde7ad5cc602e28fe55774e739
Submitter: Zuul
Branch: master

commit 4b471012de5613cde7ad5cc602e28fe55774e739
Author: zhangqing <email address hidden>
Date: Mon Apr 20 15:56:51 2020 +0800

    fix bug in consume from share

    update provisioned_capacity_gb and allocated_capacity_gb

    Closes-bug: #1872873
    Change-Id: Ic239abafcb68063f3a6b007487141e5bb8315e0d

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/722178

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/723655

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/train)

Reviewed: https://review.opendev.org/722178
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6a4eab05563d5795c7ea7f986729aeda8b95c2be
Submitter: Zuul
Branch: stable/train

commit 6a4eab05563d5795c7ea7f986729aeda8b95c2be
Author: zhangqing <email address hidden>
Date: Mon Apr 20 15:56:51 2020 +0800

    fix bug in consume from share

    update provisioned_capacity_gb and allocated_capacity_gb

    Closes-bug: #1872873
    Change-Id: Ic239abafcb68063f3a6b007487141e5bb8315e0d
    (cherry picked from commit 4b471012de5613cde7ad5cc602e28fe55774e739)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/724015

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/stein)

Reviewed: https://review.opendev.org/723655
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=429b5d297b012b1d0696b6482706070eab03dc72
Submitter: Zuul
Branch: stable/stein

commit 429b5d297b012b1d0696b6482706070eab03dc72
Author: zhangqing <email address hidden>
Date: Mon Apr 20 15:56:51 2020 +0800

    fix bug in consume from share

    update provisioned_capacity_gb and allocated_capacity_gb

    Closes-bug: #1872873
    Change-Id: Ic239abafcb68063f3a6b007487141e5bb8315e0d
    (cherry picked from commit 4b471012de5613cde7ad5cc602e28fe55774e739)
    (cherry picked from commit 6a4eab05563d5795c7ea7f986729aeda8b95c2be)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/rocky)

Reviewed: https://review.opendev.org/724015
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=36f6e95033111f5c0b75dba378c7ca270e1e1631
Submitter: Zuul
Branch: stable/rocky

commit 36f6e95033111f5c0b75dba378c7ca270e1e1631
Author: zhangqing <email address hidden>
Date: Mon Apr 20 15:56:51 2020 +0800

    fix bug in consume from share

    update provisioned_capacity_gb and allocated_capacity_gb

    Closes-bug: #1872873
    Change-Id: Ic239abafcb68063f3a6b007487141e5bb8315e0d
    (cherry picked from commit 4b471012de5613cde7ad5cc602e28fe55774e739)
    (cherry picked from commit 6a4eab05563d5795c7ea7f986729aeda8b95c2be)
    (cherry picked from commit 429b5d297b012b1d0696b6482706070eab03dc72)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/726229

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/queens)

Reviewed: https://review.opendev.org/726229
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=536572e9a8ec6df64bb3ddddb7909d37fe32d829
Submitter: Zuul
Branch: stable/queens

commit 536572e9a8ec6df64bb3ddddb7909d37fe32d829
Author: zhangqing <email address hidden>
Date: Mon Apr 20 15:56:51 2020 +0800

    fix bug in consume from share

    update provisioned_capacity_gb and allocated_capacity_gb

    Closes-bug: #1872873
    Change-Id: Ic239abafcb68063f3a6b007487141e5bb8315e0d
    (cherry picked from commit 4b471012de5613cde7ad5cc602e28fe55774e739)
    (cherry picked from commit 6a4eab05563d5795c7ea7f986729aeda8b95c2be)
    (cherry picked from commit 429b5d297b012b1d0696b6482706070eab03dc72)
    (cherry picked from commit 36f6e95033111f5c0b75dba378c7ca270e1e1631)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila queens-eol

This issue was fixed in the openstack/manila queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila rocky-eol

This issue was fixed in the openstack/manila rocky-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.