stable branch py2 IPv6 jobs are broken because of incompatible changes to neutron-tempest-plugin

[Goutham Pacha Ravi]

manila's IPv6 jobs setup bgp with the help of neutron-dynamic-routing.
The jobs enable neutron-dynamic-routing using its devstack
plugin to install it alongside openstack/neutron.

neutron-tempest-plugin is a "branchless" tempest plugin to the
neutron project. We don't need to install or run this tempest
plugin in manila test jobs. However, it is imported by test code
within the neutron-dynamic-routing project, forcing us to include
it in the list of requirements for the IPv6 jobs.

neutron-tempest-plugin dropped support for python3 in ussuri. python3 only
code was added to neutron-tempest-plugin causing failures in the voting
ipv6 lvm test job (manila-tempest-minimal-dsvm-lvm) on stable/stein:

2020-03-24 19:12:07.933 | =========================
2020-03-24 19:12:07.937 | Failures during discovery
2020-03-24 19:12:07.941 | =========================
2020-03-24 19:12:07.944 | --- import errors ---
2020-03-24 19:12:07.947 | Failed to import test module: neutron_tempest_plugin.scenario.test_floatingip
2020-03-24 19:12:07.950 | Traceback (most recent call last):
2020-03-24 19:12:07.954 | File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 456, in _find_test_path
2020-03-24 19:12:07.956 | module = self._get_module_from_name(name)
2020-03-24 19:12:07.960 | File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
2020-03-24 19:12:07.963 | __import__(name)
2020-03-24 19:12:07.966 | File "/opt/stack/new/neutron-tempest-plugin/neutron_tempest_plugin/scenario/test_floatingip.py", line 35, in <module>
2020-03-24 19:12:07.969 | from neutron_tempest_plugin.scenario import test_qos
2020-03-24 19:12:07.972 | File "/opt/stack/new/neutron-tempest-plugin/neutron_tempest_plugin/scenario/test_qos.py", line 309
2020-03-24 19:12:07.975 | SyntaxError: Non-ASCII character '\xc2' in file /opt/stack/new/neutron-tempest-plugin/neutron_tempest_plugin/scenario/test_qos.py on line 310, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
2020-03-24 19:12:07.978 |
2020-03-24 19:12:07.981 | Failed to import test module: neutron_tempest_plugin.scenario.test_qos
2020-03-24 19:12:07.984 | Traceback (most recent call last):
2020-03-24 19:12:07.987 | File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 456, in _find_test_path
2020-03-24 19:12:07.990 | module = self._get_module_from_name(name)
2020-03-24 19:12:07.993 | File "/usr/local/lib/python2.7/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
2020-03-24 19:12:07.996 | __import__(name)
2020-03-24 19:12:07.999 | File "/opt/stack/new/neutron-tempest-plugin/neutron_tempest_plugin/scenario/test_qos.py", line 309
2020-03-24 19:12:08.001 | SyntaxError: Non-ASCII character '\xc2' in file /opt/stack/new/neutron-tempest-plugin/neutron_tempest_plugin/scenario/test_qos.py on line 310, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
2020-03-24 19:12:08.004 |
2020-03-24 19:12:08.007 | ================================================================================
2020-03-24 19:12:08.011 | The above traceback was encountered during test discovery which imports all the found test modules in the specified test_path.

This plugin is being dropped from manila's master branch jobs (Ussuri cycle), so we just need to find a solution for the affected stable branches.

We run a python2 ipv6 job (manila-tempest-minimal-dsvm-lvm) in stable/stein, stable/rocky, stable/queens and stable/pike at the moment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/714806

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/714806
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=9b2753084559bf8fe415770e71e18a1477760ddb
Submitter: Zuul
Branch: stable/stein

commit 9b2753084559bf8fe415770e71e18a1477760ddb
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Mar 24 18:58:45 2020 -0700

    [stable-only] Pin neutron-tempest-plugin to 0.9.0

    manila's IPv6 jobs setup bgp with the help of
    neutron-dynamic-routing. The jobs enable
    neutron-dynamic-routing using its devstack
    plugin to install it alongside openstack/neutron.

    neutron-tempest-plugin is a "branchless" tempest
    plugin to the neutron project. We don't need to
    install or run this tempest plugin in manila test
    jobs. However, it is imported by test code within
    the neutron-dynamic-routing project, forcing us to
    include it in the list of requirements for the IPv6
    jobs.

    neutron-tempest-plugin dropped support for python3
    in ussuri. python3 only code was added to
    neutron-tempest-plugin causing failures in the
    voting ipv6 lvm test job
    (manila-tempest-minimal-dsvm-lvm).

    So, pin the version of neutron-tempest-plugin we're
    pulling in to a tagged git ref when the plugin last
    supported python2.

    Change-Id: I82854d0f9075e6fc7d33c6459d71d7f0d502ff3c
    Closes-Bug: #1868905
    Signed-off-by: Goutham Pacha Ravi <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/714949

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/714949
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c856f4ffa245c14c2233d95c94c10fb3577d519c
Submitter: Zuul
Branch: stable/rocky

commit c856f4ffa245c14c2233d95c94c10fb3577d519c
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Mar 24 18:58:45 2020 -0700

    [stable-only] Pin neutron-tempest-plugin to 0.9.0

    manila's IPv6 jobs setup bgp with the help of
    neutron-dynamic-routing. The jobs enable
    neutron-dynamic-routing using its devstack
    plugin to install it alongside openstack/neutron.

    neutron-tempest-plugin is a "branchless" tempest
    plugin to the neutron project. We don't need to
    install or run this tempest plugin in manila test
    jobs. However, it is imported by test code within
    the neutron-dynamic-routing project, forcing us to
    include it in the list of requirements for the IPv6
    jobs.

    neutron-tempest-plugin dropped support for python3
    in ussuri. python3 only code was added to
    neutron-tempest-plugin causing failures in the
    voting ipv6 lvm test job
    (manila-tempest-minimal-dsvm-lvm).

    So, pin the version of neutron-tempest-plugin we're
    pulling in to a tagged git ref when the plugin last
    supported python2.

    Change-Id: I82854d0f9075e6fc7d33c6459d71d7f0d502ff3c
    Closes-Bug: #1868905
    Signed-off-by: Goutham Pacha Ravi <email address hidden>
    (cherry picked from commit 9b2753084559bf8fe415770e71e18a1477760ddb)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 8.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila rocky-eol release.