manila manage OverQuota - no good way out

[Maurice Escher]

Hi,

I managed a share in a project without share and gigabytes quota. The share goes into state manage_error, I see an OverQuota Error in the log.

The share instance is already present at this time and the share has been renamed in the back end.

I tested this with netapp back end (dhss=true, but the code for manage_existing is in the common lib_base, should be the same for dhss=false).

I don't see a good way out of this situation now, I tried:

A) manila reset state:
- cool, I tricked the quota system
- but the export location is wrong (still shows the one I imported from, but on the back end it is already renamed; keyword junction path on netapp)
B) manila delete:
- failed with 403 Invalid share: Share status must be one of ('available', 'error', 'inactive')
C) manila force delete:
- oops this removes more than I wanted, also my back end share is gone
D) manila reset state and then manila delete:
- same as option C)

To keep my back end share and to get rid of the share in manage_error I would either need to go to the database directly or to the back end directly - both options are ugly. And may not be an option for an administrative user, who only has the API (and some info about manageable shares) to work with.

I suggest to do the quota check earlier, to fail faster before the connection to the back end share has been made.

Cheers,
Maurice

[Vida Haririan (vhariria)]

Revisted see http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-02-20-15.00.log.html

[Carlos Eduardo (silvacarlose)]

We are discussing approaches to fix this bug in [1].

[1] https://etherpad.opendev.org/p/manila-manage-overquota-bug

[Carlos Eduardo (silvacarlose)]

After some discussion, we have agreed to use the following approach to fix the bug:

While managing a share, even if there are no available quotas the operation will be completed by allowing the quotas to be exceeded, and the service will log a warning. Since the quotas are going to be exceeded, some other operations that also need to allocate resources are going to be blocked by the OverQuota error, so the administrator will need to adjust the quotas to make this operations work again.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/722418

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/722418
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=413e5e6d08789d39897b5db24f2fc1371d24ced2
Submitter: Zuul
Branch: master

commit 413e5e6d08789d39897b5db24f2fc1371d24ced2
Author: silvacarloss <email address hidden>
Date: Mon Apr 20 18:24:34 2020 +0000

    Fix manila OverQuota issue while managing shares

    Fixes the OverQuota issue while managing shares. Now, when a share
    manage request is received and there is no available quota to this
    resource, manila will allow the quotas to be exceeded and the
    administrator will need to adjust it.

    Change-Id: If6edfa79965f1a0e6959b436c53a714217d23f7d
    Closes-Bug: #1863298

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/753294

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/753294
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3d3eb35c1391cd0aa639230b34402c580858b281
Submitter: Zuul
Branch: stable/ussuri

commit 3d3eb35c1391cd0aa639230b34402c580858b281
Author: silvacarloss <email address hidden>
Date: Mon Apr 20 18:24:34 2020 +0000

    Fix manila OverQuota issue while managing shares

    Fixes the OverQuota issue while managing shares. Now, when a share
    manage request is received and there is no available quota to this
    resource, manila will allow the quotas to be exceeded and the
    administrator will need to adjust it.

    Change-Id: If6edfa79965f1a0e6959b436c53a714217d23f7d
    Closes-Bug: #1863298
    (cherry picked from commit 413e5e6d08789d39897b5db24f2fc1371d24ced2)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/756509

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 10.0.2 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/756509
Committed: https://opendev.org/openstack/manila/commit/e138c469d6bf1f3c0527bf37dacc6200b456bb96
Submitter: "Zuul (22348)"
Branch: stable/train

commit e138c469d6bf1f3c0527bf37dacc6200b456bb96
Author: silvacarloss <email address hidden>
Date: Mon Apr 20 18:24:34 2020 +0000

    Fix manila OverQuota issue while managing shares

    Fixes the OverQuota issue while managing shares. Now, when a share
    manage request is received and there is no available quota to this
    resource, manila will allow the quotas to be exceeded and the
    administrator will need to adjust it.

    Change-Id: If6edfa79965f1a0e6959b436c53a714217d23f7d
    Closes-Bug: #1863298
    (cherry picked from commit 413e5e6d08789d39897b5db24f2fc1371d24ced2)
    (cherry picked from commit 3d3eb35c1391cd0aa639230b34402c580858b281)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila train-eol release.