share list detail slow database access

[Maurice Escher]

Hi,

shares have a lot of relations and thus a listing of share details results in a lot database queries. Looking at the sqlalchemy models there is room for improvement.

I will send a suggested fix.

Best,
Maurice

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/702639

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/702639
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=54c5667e6b4a37270c4aed64b9a5ebd5f31bfa16
Submitter: Zuul
Branch: master

commit 54c5667e6b4a37270c4aed64b9a5ebd5f31bfa16
Author: Sebastian Lohff <email address hidden>
Date: Wed Jun 19 16:21:19 2019 +0200

    Improve share list speed using lazy='subquery'

    lazy='immediate' leads to each relationship being collected when
    it is accessed. This results in at least three extra queries when
    we query for all share details. lazy='subquery' collects all data
    when the query is executed. In this commit we only changed code for
    improving the share list with details ("manila list") speed.

    Change-Id: Ia61b108ece0817069737980a614cc6c15c1a3507
    Closes-Bug: #1859785
    Co-authored-by: Johannes Kulik <email address hidden>
    Co-authored-by: Maurice Escher <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/704850

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/704850
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f01e48557863a4b6d4e75fe368e0185652aab09f
Submitter: Zuul
Branch: stable/train

commit f01e48557863a4b6d4e75fe368e0185652aab09f
Author: Sebastian Lohff <email address hidden>
Date: Wed Jun 19 16:21:19 2019 +0200

    Improve share list speed using lazy='subquery'

    lazy='immediate' leads to each relationship being collected when
    it is accessed. This results in at least three extra queries when
    we query for all share details. lazy='subquery' collects all data
    when the query is executed. In this commit we only changed code for
    improving the share list with details ("manila list") speed.

    Change-Id: Ia61b108ece0817069737980a614cc6c15c1a3507
    Closes-Bug: #1859785
    Co-authored-by: Johannes Kulik <email address hidden>
    Co-authored-by: Maurice Escher <email address hidden>
    (cherry picked from commit 54c5667e6b4a37270c4aed64b9a5ebd5f31bfa16)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/704897

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/704897
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=dd35b08de1c2b5c9af835579ed5a07e527fa8a65
Submitter: Zuul
Branch: stable/stein

commit dd35b08de1c2b5c9af835579ed5a07e527fa8a65
Author: Sebastian Lohff <email address hidden>
Date: Wed Jun 19 16:21:19 2019 +0200

    Improve share list speed using lazy='subquery'

    lazy='immediate' leads to each relationship being collected when
    it is accessed. This results in at least three extra queries when
    we query for all share details. lazy='subquery' collects all data
    when the query is executed. In this commit we only changed code for
    improving the share list with details ("manila list") speed.

    Change-Id: Ia61b108ece0817069737980a614cc6c15c1a3507
    Closes-Bug: #1859785
    Co-authored-by: Johannes Kulik <email address hidden>
    Co-authored-by: Maurice Escher <email address hidden>
    (cherry picked from commit 54c5667e6b4a37270c4aed64b9a5ebd5f31bfa16)
    (cherry picked from commit f01e48557863a4b6d4e75fe368e0185652aab09f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 9.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 8.1.1 release.