manila service list shows up for uninitialized driver

Bug #1853940 reported by haixin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
haixin

Bug Description

there is a problem with a manila driver not initializing correctly, but the manila service is up.
For example, i add a new driver to manila.conf and enabled it, then i restart manila-share, i found
manila service-list shows the status of this driver is UP. but now this backend has not initialized yet,
that means this backend can not be "up" status before the driver initialized successed.

this bug will lead to some share action error, will return driver is uninitialized. although manila service-list shows "UP". so we need to fix it.

haixin (haixin77)
Changed in manila:
assignee: nobody → haixin (haixin77)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/697957

Changed in manila:
status: New → In Progress
Tom Barron (tpb)
Changed in manila:
importance: Undecided → Medium
milestone: none → ussuri-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/697957
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=37a9e5388d504b0e4e4c58c9f22d0703391378a0
Submitter: Zuul
Branch: master

commit 37a9e5388d504b0e4e4c58c9f22d0703391378a0
Author: haixin <email address hidden>
Date: Mon Dec 9 03:48:48 2019 -0500

    Don't send heartbeats if driver not initializing correctly

    This commit adds is_service_ready method to base Manager class that can be
    used to indicate that service is not ready or initialzed success. This is
    used to block refreshing Service heartbeats if manager will return false
    from is_service_ready.

    Closes-Bug:#1853940

    Change-Id: Ib85468c703dfa51b03d1838bd422c9b2669bc747

Changed in manila:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.