[tempest] test_manage_share_server_invalid_params fails on stable branches

[Goutham Pacha Ravi]

A negative test for the share server manage API was added with review https://review.opendev.org/#/c/676475/:

https://opendev.org/openstack/manila-tempest-plugin/src/commit/92925822a3f63e8ead84be7736416829f4ce69f1/manila_tempest_tests/tests/api/admin/test_share_servers_manage_negative.py#L74-L122

The third test case with this test invokes the manage share server API with the parameter: share_network_subnet_id - in older versions of the Manila API, this parameter is unknown, and is allowed (because manila APIs do not perform any kind of JSON schema validation)

This causes the test to fail with the following traceback:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/ddt.py", line 145, in wrapper
    return func(self, *args, **kwargs)
  File "/opt/stack/new/manila-tempest-plugin/manila_tempest_tests/tests/api/admin/test_share_servers_manage_negative.py", line 106, in test_manage_share_server_invalid_params
    invalid_params
  File "/usr/local/lib/python3.6/dist-packages/testtools/testcase.py", line 485, in assertRaises
    self.assertThat(our_callable, matcher)
  File "/usr/local/lib/python3.6/dist-packages/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: <bound method BaseSharesAdminTest._manage_share_server of <manila_tempest_tests.tests.api.admin.test_share_servers_manage_negative.ManageShareServersNegativeTest.test_manage_share_server_invalid_params_3___share_network_subnet_id____invalid_share_network_subnet_id__[api_with_backend,negative] id=0x7f322a311ac8>> returned {'id': '5a9b391b-2e9e-4e35-84b3-f7dd1c0ea571', 'project_id': '7daa382cc1da4609a09cbf06ed30985b', 'updated_at': None, 'status': 'manage_starting', 'host': 'ubuntu-bionic-rax-ord-0011938659@alpha', 'share_network_name': '06195f1e-3242-4492-aea8-972be424be30', 'share_network_id': '06195f1e-3242-4492-aea8-972be424be30', 'created_at': '2019-09-27T15:07:56.000000', 'backend_details': {}, 'is_auto_deletable': False, 'identifier': 'ccfe88e5-f531-489d-8d5f-120d25167d78'}

This test-case ought to be skipped for API versions lesser than 2.51.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/685496

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/685496
Committed: https://git.openstack.org/cgit/openstack/manila-tempest-plugin/commit/?id=e5606387bebf53aba19365f1864c2d022b8b1bf4
Submitter: Zuul
Branch: master

commit e5606387bebf53aba19365f1864c2d022b8b1bf4
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Sep 27 14:32:35 2019 -0700

    Skip subnets test when version 2.51 is not supported

    Change-Id: I0591d7d08e09a6a5d4b195f55fa22157207face3
    Closes-Bug: #1845726

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila-tempest-plugin 0.4.1 release.