OpenStack Shared File Systems Service (Manila)

Unity: Failed to delete CIFS share if invalid access was set

Bug #1845452 reported by Yong Huang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Yong Huang

Bug Description

Reproduce steps:
1. Create CIFS share
2. Set access-allow with non-existence user
2. Delete the CIFS share

Logs:

Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server [None req-1aa20c01-7785-443a-bb0f-f30e5bf7faa9 None None] Exception during message handling: UnityAclUserNotFoundError: A
CL User hasn't been found. Please check that username and domain are correct. (Error Code:0x60000cb)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server Traceback (most recent call last):
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/server.py", line 165, in _process_incoming
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 274, in dispatch
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 194, in _do_dispatch
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 187, in wrapped
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server return f(self, *args, **kwargs)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/utils.py", line 568, in wrapper
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server return func(self, *args, **kwargs)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 3555, in update_access
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server share_server=share_server)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/access.py", line 283, in update_access_rules
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server share_server=share_server)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/access.py", line 322, in _update_access_rules
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server share_server)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/access.py", line 390, in _update_rules_through_share_driver
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server share_server=share_server
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/dell_emc/driver.py", line 156, in update_access
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server delete_rules, share_server)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/dell_emc/common/enas/utils.py", line 52, in inner
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server ret = func(self, *args, **kwargs)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/dell_emc/plugins/unity/connection.py", line 343, in update_access
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server self.allow_access(context, share, rule, share_server)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/dell_emc/common/enas/utils.py", line 52, in inner
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server ret = func(self, *args, **kwargs)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/dell_emc/plugins/unity/connection.py", line 378, in allow_access
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server self._cifs_allow_access(share, access)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/dell_emc/plugins/unity/connection.py", line 504, in _cifs_allow_access
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server share['id'], access['access_to'], access['access_level'])
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/dell_emc/plugins/unity/client.py", line 264, in cifs_allow_access
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server share.add_ace(user=user_name, access_level=cifs_access)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/home/stack/storops/storops/unity/resource/cifs_share.py", line 142, in add_ace
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server sid = UnityAclUser.get_sid(self._cli, user=user, domain=domain)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/home/stack/storops/storops/unity/resource/cifs_share.py", line 274, in get_sid
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server resp.raise_if_err()
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server File "/home/stack/storops/storops/unity/resp.py", line 131, in raise_if_err
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server raise ex_clz(self.error)
Sep 25 20:06:29 openstack-huangy18-01 manila-share[5631]: ERROR oslo_messaging.rpc.server UnityAclUserNotFoundError: ACL User hasn't been found. Please check that username and domain are correct. (Error Code:0x6
0000cb)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/684964

Changed in manila:
assignee: nobody → Yong Huang (yonghuang)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/684964
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0103c3aa9254f679d29ca8b7f6615f5646b0f029
Submitter: Zuul
Branch: master

commit 0103c3aa9254f679d29ca8b7f6615f5646b0f029
Author: Yong Huang <email address hidden>
Date: Wed Sep 25 20:36:28 2019 -0400

    [Unity]: Failed to delete cifs share if wrong access set

    If wrong access was set, CIFS share won't be able to delete.

    Change-Id: Ie1c47dcbd53f7f49d9a8669e9912bb88abd6ac30
    Closes-bug: #1845452

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/710877

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/train)

Reviewed: https://review.opendev.org/710877
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=b3d6254e35f2f81be2df772eb7cd19d3bc32391d
Submitter: Zuul
Branch: stable/train

commit b3d6254e35f2f81be2df772eb7cd19d3bc32391d
Author: Yong Huang <email address hidden>
Date: Wed Sep 25 20:36:28 2019 -0400

    [Unity]: Failed to delete cifs share if wrong access set

    If wrong access was set, CIFS share won't be able to delete.

    Depends-On: I624e1dc57a3d3533322fb298c01f70241d0400ed
    Change-Id: Ie1c47dcbd53f7f49d9a8669e9912bb88abd6ac30
    Closes-bug: #1845452
    (cherry picked from commit 0103c3aa9254f679d29ca8b7f6615f5646b0f029)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/724507

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/stein)

Reviewed: https://review.opendev.org/724507
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=d1c42a02a9737c2f03383345b236eacd31f9267a
Submitter: Zuul
Branch: stable/stein

commit d1c42a02a9737c2f03383345b236eacd31f9267a
Author: Yong Huang <email address hidden>
Date: Wed Sep 25 20:36:28 2019 -0400

    [Unity]: Failed to delete cifs share if wrong access set

    If wrong access was set, CIFS share won't be able to delete.

    Depends-On: I624e1dc57a3d3533322fb298c01f70241d0400ed
    Change-Id: Ie1c47dcbd53f7f49d9a8669e9912bb88abd6ac30
    Closes-bug: #1845452
    (cherry picked from commit 0103c3aa9254f679d29ca8b7f6615f5646b0f029)
    (cherry picked from commit b3d6254e35f2f81be2df772eb7cd19d3bc32391d)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/726286

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/rocky)

Reviewed: https://review.opendev.org/726286
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6c3bd6600bb9efbc4c21ba3f5903675f72f8c2db
Submitter: Zuul
Branch: stable/rocky

commit 6c3bd6600bb9efbc4c21ba3f5903675f72f8c2db
Author: Yong Huang <email address hidden>
Date: Wed Sep 25 20:36:28 2019 -0400

    [Unity]: Failed to delete cifs share if wrong access set

    If wrong access was set, CIFS share won't be able to delete.

    Depends-On: I624e1dc57a3d3533322fb298c01f70241d0400ed
    Change-Id: Ie1c47dcbd53f7f49d9a8669e9912bb88abd6ac30
    Closes-bug: #1845452
    (cherry picked from commit 0103c3aa9254f679d29ca8b7f6615f5646b0f029)
    (cherry picked from commit b3d6254e35f2f81be2df772eb7cd19d3bc32391d)
    (cherry picked from commit d1c42a02a9737c2f03383345b236eacd31f9267a)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila rocky-eol

This issue was fixed in the openstack/manila rocky-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.