Manila unexpectedly attempts to delete a share server when deleting a share network

[Carlos Eduardo]

After the manage/unmanage with DHSS=True patch was merged, when I delete a share network, manila tries to delete its share server even if it's not auto deletable.

Steps:
- Create a share network sn_1
- Create a share s1 inside sn_1
- Unmanage s1
- Delete sn_1

Expected behavior: An error message is shown saying that the share network still contains a share server that cannot be deleted.

Actual behavior: The share network is deleted and the share server is left in error state.

[Carlos Eduardo (silvacarlose)]

The share server is left with the flag is_auto_deletable = False in two scenarios:

1. The share server was managed
2. Its share was unmanaged

[Carlos Eduardo (silvacarlose)]

The error message should be defined for this scenario. We should consider that deleting a share network doesn't require admin privileges, but deleting a share server does.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/644560

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/645190

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/644905
Committed: https://git.openstack.org/cgit/openstack/manila-tempest-plugin/commit/?id=9743939c6cd1ac48efe705388abf30165718f27e
Submitter: Zuul
Branch: master

commit 9743939c6cd1ac48efe705388abf30165718f27e
Author: Lucio Seki <email address hidden>
Date: Tue Mar 19 18:05:35 2019 -0300

    Delete servers before deleting its share network

    When deleting a share network, the belonging share servers were being
    deleted automatically. However, any possible errors were being ignored,
    possibly leaving share servers in the backend.

    The patch https://review.openstack.org/644560 avoids this by making the
    Manila API to return an error if the share network about to be deleted
    still has any share server, which in turn has `is_auto_deletable=True`
    or contains any share.

    This patch modifies the base test class tearDown method, to delete the
    share servers before the share network they belong to.

    Change-Id: I7d330b8b5fb3f08d3cbdae2c1735e266e75a70d3
    Depends-On: I4144a532d5827b929a1dce0d4d642e6d1cee47b1
    Related-Bug: #1820118

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/644560
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f4fc7aa08a8b2d4e7bba02af49bd84ea30d2fcac
Submitter: Zuul
Branch: master

commit f4fc7aa08a8b2d4e7bba02af49bd84ea30d2fcac
Author: silvacarloss <email address hidden>
Date: Mon Mar 18 14:14:51 2019 -0300

    Fix server delete attempt along with share net deletion

    This bug was introduced when manage/unmange servers with DHSS=True
    was merged. This behavior is expected except in two scenarios:

    1. If the share server was managed;
    2. If any share belonging to this share server was unmanaged;

    In both cases, the `is_auto_deletable` field is set to False. This
    field was added to prevent the share server from being deleted by
    the periodic cleanup job.

    This patch fixes the bug by checking the `is_auto_deletable` field
    when the share network deletion triggers the share server deletion.

    APIImpact

    Change-Id: Ib83b8222100fd5a3d718ad2cb7887b1d79ebd546
    Depends-On: I7d330b8b5fb3f08d3cbdae2c1735e266e75a70d3
    Closes-bug: #1820118

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 8.0.0.0rc1 release candidate.