NetApp drivrer fails to create share from snapshot on py3

Bug #1815587 reported by Carlos Eduardo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Carlos Eduardo

Bug Description

I got an error while trying to create a share from a snapshot on py3 in the NetApp driver.

Setup:
- Ubuntu 18.04 with 8gb RAM and Manila configurated with py3

Steps:
- Create a new share
- Create a new snapshot
- Create a new share from snapshot

Stacktrace:
Feb 12 11:01:10.632796 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR manila.share.manager [None req-fe94a706-6d33-4cc8-9c0a-a7f4055b72bf None None] Share instance 2ce40ba7-c055-4f
cb-b2be-da8ea3809268 failed on creation.
Feb 12 11:01:10.632995 15-carlos-manila-master-dhsstrue manila-share[15782]: WARNING manila.share.manager [None req-fe94a706-6d33-4cc8-9c0a-a7f4055b72bf None None] Share instance information in
 exception can not be written to db because it contains {} and it is not a dictionary.
Feb 12 11:01:10.697407 15-carlos-manila-master-dhsstrue manila-share[15782]: INFO manila.message.api [None req-fe94a706-6d33-4cc8-9c0a-a7f4055b72bf None None] Creating message record for reques
t_id = req-fe94a706-6d33-4cc8-9c0a-a7f4055b72bf
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server [None req-fe94a706-6d33-4cc8-9c0a-a7f4055b72bf None None] Exception during message h
andling: TypeError: '>' not supported between instances of 'int' and 'NoneType'
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server Traceback (most recent call last):
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/usr/local/lib/python3.6/dist-packages/oslo_messaging/rpc/server.py", line 1
66, in _process_incoming
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/usr/local/lib/python3.6/dist-packages/oslo_messaging/rpc/dispatcher.py", li
ne 265, in dispatch
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/usr/local/lib/python3.6/dist-packages/oslo_messaging/rpc/dispatcher.py", li
ne 194, in _do_dispatch
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 186, in wrapped
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server return f(self, *args, **kwargs)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/utils.py", line 569, in wrapper
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server return func(self, *args, **kwargs)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 1772, in create_share_instance
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server exception=e)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/usr/local/lib/python3.6/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server self.force_reraise()
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/usr/local/lib/python3.6/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/usr/local/lib/python3.6/dist-packages/six.py", line 693, in reraise
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server raise value
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 1732, in create_share_instance
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server share_server=share_server)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/drivers/netapp/dataontap/cluster_mode/drv_multi_svm.py", line 53, in create_share_from_snapshot
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server snapshot, **kwargs)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/drivers/netapp/utils.py", line 96, in trace_wrapper
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server result = f(self, *args, **kwargs)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py", line 483, in create_share_from_snapshot
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server share, snapshot, vserver, vserver_client)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/drivers/netapp/utils.py", line 96, in trace_wrapper
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server result = f(self, *args, **kwargs)
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py", line 778, in _allocate_container_from_snapshot
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server if share['size'] > snapshot['size']:
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server TypeError: '>' not supported between instances of 'int' and 'NoneType'
Feb 12 11:01:10.765378 15-carlos-manila-master-dhsstrue manila-share[15782]: ERROR oslo_messaging.rpc.server

Tom Barron (tpb)
tags: added: driver netapp python3
Changed in manila:
importance: Undecided → High
milestone: none → stein-3
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/638681

Changed in manila:
assignee: Rodrigo Barbieri (rodrigo-barbieri2010) → Carlos Eduardo (silvacarlose)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/638681
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=785aa8369c5a7a04b5358ca2c66aa18a4f9637e1
Submitter: Zuul
Branch: master

commit 785aa8369c5a7a04b5358ca2c66aa18a4f9637e1
Author: silvacarloss <email address hidden>
Date: Mon Feb 11 15:27:06 2019 -0200

    Fix missing size value in snapshot instance

    This patch fixes the size value not being present in share
    snapshot instances, which causes drivers to not being able to access
    this property unless they read the size from the snapshot model.

    Closes-bug: #1815587
    Change-Id: I730629ea460c316a02f8dffb4a55eea04ad619c9

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 8.0.0.0rc1

This issue was fixed in the openstack/manila 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.