API is not reachable if manila is deployed with uWSGI and mounted in /share
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Manila |
Medium
|
Goutham Pacha Ravi |
Bug Description
As part of the effort of deploying manila in devstack by default with uWSGI, it was noticed that URLs with the form HOSTNAME[
Excerpt from gate log:
Feb 06 19:22:05.693033 ubuntu-
Feb 06 19:22:05.693033 ubuntu-
Feb 06 19:22:05.693033 ubuntu-
Feb 06 19:22:05.693033 ubuntu-
Feb 06 19:22:05.693033 ubuntu-
Feb 06 19:22:05.693033 ubuntu-
Feb 06 19:22:05.744883 ubuntu-
Feb 06 19:22:06.087746 ubuntu-
Changed in manila: | |
assignee: | nobody → Victoria Martinez de la Cruz (vkmc) |
Changed in manila: | |
status: | New → In Progress |
Fix proposed to branch: master
Review: https:/
Changed in manila: | |
assignee: | Victoria Martinez de la Cruz (vkmc) → Goutham Pacha Ravi (gouthamr) |
Changed in manila: | |
assignee: | Goutham Pacha Ravi (gouthamr) → Victoria Martinez de la Cruz (vkmc) |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 50a6760a64bc67a
Author: Goutham Pacha Ravi <email address hidden>
Date: Thu Feb 14 13:35:52 2019 -0800
Fix microversion request URL
The code in the client assumes that we're hitting the
base URL. However, the manila endpoint URL isn't always
of the format HOST[:PORT]
that the endpoint URL pertains to a proxy configuration
which is of the format
HOST/
This patch also adds logging to the microversion
request since we're using tempest's "raw_request"
which doesn't do logging for us.
Change-Id: I50906ec245b965
Partial-Bug: #1815038
Changed in manila: | |
importance: | Undecided → Medium |
status: | In Progress → Fix Committed |
milestone: | none → stein-3 |
status: | Fix Committed → In Progress |
Fix proposed to branch: master
Review: https:/
Changed in manila: | |
assignee: | Victoria Martinez de la Cruz (vkmc) → Goutham Pacha Ravi (gouthamr) |
Change abandoned by Goutham Pacha Ravi (<email address hidden>) on branch: master
Review: https:/
Reason: This is bound to fail, so will propose an alternative fix
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 6d970b7375689eb
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Thu Feb 7 12:56:42 2019 +0000
Extend remove_
Improve remove_
the version does not directly trail the hostname
Given: 'http://
Returns: 'http://
Based on I8ccc449116ff16
Change-Id: I13010d3ee0a83a
Closes-Bug: #1815038
Changed in manila: | |
status: | In Progress → Fix Released |
OpenStack Infra (hudson-openstack) wrote : | #7 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 0d8310ec7a169f6
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Feb 27 11:58:58 2019 -0800
Fix version selector when for proxy-style URLs
When manila API is served behind a proxy, the
"script_name" in the request can have the proxy
component in it. So, this patch fixes the version
selection logic by looking for the version in the
script name string instead of equivalence.
In addition, this patch adds some missing unit
tests and fixes tests that invoke a mocked
wsgi app for testing request context.
Change-Id: I0363d7174f3d7d
Partial-Bug: #1815038
Closes-Bug: #1818081
Fix proposed to branch: stable/rocky
Review: https:/
OpenStack Infra (hudson-openstack) wrote : | #9 |
Fix proposed to branch: stable/rocky
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/rocky
commit 670449f3e121301
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Thu Feb 7 12:56:42 2019 +0000
Extend remove_
Improve remove_
the version does not directly trail the hostname
Given: 'http://
Returns: 'http://
Based on I8ccc449116ff16
Change-Id: I13010d3ee0a83a
Closes-Bug: #1815038
(cherry picked from commit 6d970b7375689eb
tags: | added: in-stable-rocky |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/rocky
commit 6b39562c0e0fc44
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Feb 27 11:58:58 2019 -0800
Fix version selector when for proxy-style URLs
When manila API is served behind a proxy, the
"script_name" in the request can have the proxy
component in it. So, this patch fixes the version
selection logic by looking for the version in the
script name string instead of equivalence.
In addition, this patch adds some missing unit
tests and fixes tests that invoke a mocked
wsgi app for testing request context.
Change-Id: I0363d7174f3d7d
Partial-Bug: #1815038
Closes-Bug: #1818081
(cherry picked from commit 0d8310ec7a169f6
Fix proposed to branch: stable/queens
Review: https:/
Fix proposed to branch: stable/queens
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit 587a1b2ad319342
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Feb 27 11:58:58 2019 -0800
Fix version selector when for proxy-style URLs
When manila API is served behind a proxy, the
"script_name" in the request can have the proxy
component in it. So, this patch fixes the version
selection logic by looking for the version in the
script name string instead of equivalence.
In addition, this patch adds some missing unit
tests and fixes tests that invoke a mocked
wsgi app for testing request context.
Change-Id: I0363d7174f3d7d
Partial-Bug: #1815038
Closes-Bug: #1818081
(cherry picked from commit 0d8310ec7a169f6
(cherry picked from commit 6b39562c0e0fc44
tags: | added: in-stable-queens |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit 4bfff6055b8b3af
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Thu Feb 7 12:56:42 2019 +0000
Extend remove_
Improve remove_
the version does not directly trail the hostname
Given: 'http://
Returns: 'http://
Based on I8ccc449116ff16
Change-Id: I13010d3ee0a83a
Closes-Bug: #1815038
(cherry picked from commit 6d970b7375689eb
(cherry picked from commit 670449f3e121301
This issue was fixed in the openstack/manila 8.0.0.0rc1 release candidate.
This issue was fixed in the openstack/manila 6.2.0 release.
This issue was fixed in the openstack/manila 7.2.0 release.
Fix proposed to branch: master /review. openstack. org/635502
Review: https:/