Option "share_usage_audit_period" does nothing

Bug #1813054 reported by Goutham Pacha Ravi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Goutham Pacha Ravi

Bug Description

There's an option in the [DEFAULT] group called "share_usage_audit_period" [1][2]. Setting its value does nothing in manila. This config option sounds very similar to "share_usage_size_update_interval" which was introduced in [3]

[1] https://github.com/openstack/manila/blob/70b926/manila/common/config.py#L105
[2] https://docs.openstack.org/manila/latest/configuration/shared-file-systems/config-options.html#id10
[3] https://review.openstack.org/#/c/465055/

Changed in manila:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/632799

Changed in manila:
assignee: nobody → Goutham Pacha Ravi (gouthamr)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/632799
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0f627aa6cf3250e6dba8c436a999c9f30681cc50
Submitter: Zuul
Branch: master

commit 0f627aa6cf3250e6dba8c436a999c9f30681cc50
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Jan 23 11:28:51 2019 -0800

    Deprecate [DEFAULT]/share_usage_size_audit_period

    This option is unused and is likely going to confuse
    deployers, especially when using the share usage size
    tracking feature with a similarly named option
    (share_usage_size_update_interval) [1].

    We can remove this option in the Train release.

    Closes-Bug: #1813054
    [1] https://review.openstack.org/#/c/465055/

    Change-Id: Id4585fa887e5bdfd5743dad2c490392ba0401061

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 8.0.0.0rc1

This issue was fixed in the openstack/manila 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.