Manila snapshot create method doesn't support "force" attribute

[kay]

API reference has an entry, that force parameter is supported: https://developer.openstack.org/api-ref/shared-file-system/?expanded=create-share-snapshot-detail#create-share-snapshot

The "create_snapshot" function handles the force attribute: https://github.com/openstack/manila/blob/8f88779778f76df32d43d321b45a1ba37613c514/manila/share/api.py#L981

However the API call doesn't pass this paramater: https://github.com/openstack/manila/blob/8f88779778f76df32d43d321b45a1ba37613c514/manila/api/v1/share_snapshots.py#L203

[Jason Grosso (jgrosso)]

Hi Kay was just wondering when you say "However the API call doesn't pass this parameter" whom are you expecting the API to pass the parameter too?

[kay (kay-diam)]

Sorry for the confusion, I meant, the "create" function, which doesn't pass this parameter to the "share_api.create_snapshot"

[Tom Barron (tpb)]

We discussed this at the PTG and so far as we can tell there is not actually a use case for creating snapshots from shares that are not available and we should resolve this issue by removing the option from our api doc (and some internal but really effective places in our codebase - https://github.com/openstack/manila/blob/d877b61c5e37ff012341194b8349af6f38155e5d/manila/share/api.py#L1081). If you think there are legitmate use cases please let us know.

[Jason Grosso (jgrosso)]

Hello, Kay, I am wondering if you have any input if this is a valid use case for you, thanks!

[kay (kay-diam)]

Hi Jason. I don't remember the use case, probably I tried to play with the API and then realized that this option is not passed.

[Launchpad Janitor (janitor)]

[Expired for Manila because there has been no activity for 60 days.]