[maniila image elements] custom image job fails to test the new image

[Tom Barron]

When we post a review to build a new manila service image, the custom image jobs are supposed to run with the newly built image and there is an attempt to make this happen via the pre-test-hook. It does not work, however. In the devstack log we clearly see that MANILA_SERVICE_IMAGE_URL is set to the normal, default tarballs.openstack.org value [1] instead of pointing to the new image, and that the already-published image is what is uploaded to glance for use by manila rather than the new image [2].

[1] http://logs.openstack.org/89/624389/1/check/manila-tempest-dsvm-generic-scenario-custom-image/420971f/logs/devstacklog.txt.gz#_2018-12-11_13_21_37_784

[2] http://logs.openstack.org/89/624389/1/check/manila-tempest-dsvm-generic-scenario-custom-image/420971f/logs/devstacklog.txt.gz

[Tom Barron (tpb)]

Attaching the devstack log since the gerrit logs referenced are ephemeral.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/623551
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6299ed5ed001ae2768ed2b954730b526b4053b2c
Submitter: Zuul
Branch: master

commit 6299ed5ed001ae2768ed2b954730b526b4053b2c
Author: Tom Barron <email address hidden>
Date: Fri Dec 7 12:10:15 2018 -0500

    Fix image_name retrieval in custom-image jobs

    And use a 'file://' url for the custom manila image.

    See also https://review.openstack.org/#/c/623330. These
    are interdependent patches but no harm is done by merging
    this one first and having 623330 depend on it since retrieval
    of the image name is not working correctly anyways.

    Partial-Bug: #1807969

    Change-Id: Ib3a74d170f159dfbc38b5302f00800f3530f4921

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/626888

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626888
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=758eaac8cc273c6e035cece339a4215d2ce8c6e9
Submitter: Zuul
Branch: stable/rocky

commit 758eaac8cc273c6e035cece339a4215d2ce8c6e9
Author: Tom Barron <email address hidden>
Date: Fri Dec 7 12:10:15 2018 -0500

    Fix image_name retrieval in custom-image jobs

    And use a 'file://' url for the custom manila image.

    See also https://review.openstack.org/#/c/623330. These
    are interdependent patches but no harm is done by merging
    this one first and having 623330 depend on it since retrieval
    of the image name is not working correctly anyways.

    Partial-Bug: #1807969

    Change-Id: Ib3a74d170f159dfbc38b5302f00800f3530f4921
    (cherry picked from commit 6299ed5ed001ae2768ed2b954730b526b4053b2c)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/627730

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/627730
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=68f6578adcd84598a6ce253f33e1c46c9a6b50ea
Submitter: Zuul
Branch: stable/queens

commit 68f6578adcd84598a6ce253f33e1c46c9a6b50ea
Author: Tom Barron <email address hidden>
Date: Fri Dec 7 12:10:15 2018 -0500

    Fix image_name retrieval in custom-image jobs

    And use a 'file://' url for the custom manila image.

    See also https://review.openstack.org/#/c/623330. These
    are interdependent patches but no harm is done by merging
    this one first and having 623330 depend on it since retrieval
    of the image name is not working correctly anyways.

    Partial-Bug: #1807969

    Change-Id: Ib3a74d170f159dfbc38b5302f00800f3530f4921
    (cherry picked from commit 6299ed5ed001ae2768ed2b954730b526b4053b2c)
    (cherry picked from commit 758eaac8cc273c6e035cece339a4215d2ce8c6e9)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/627981

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/627981
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=65a64521fee00240b1d9df8f444732f342e1b73f
Submitter: Zuul
Branch: stable/pike

commit 65a64521fee00240b1d9df8f444732f342e1b73f
Author: Tom Barron <email address hidden>
Date: Fri Dec 7 12:10:15 2018 -0500

    Fix image_name retrieval in custom-image jobs

    And use a 'file://' url for the custom manila image.

    See also https://review.openstack.org/#/c/623330. These
    are interdependent patches but no harm is done by merging
    this one first and having 623330 depend on it since retrieval
    of the image name is not working correctly anyways.

    Partial-Bug: #1807969

    Change-Id: Ib3a74d170f159dfbc38b5302f00800f3530f4921
    (cherry picked from commit 6299ed5ed001ae2768ed2b954730b526b4053b2c)
    (cherry picked from commit 758eaac8cc273c6e035cece339a4215d2ce8c6e9)
    (cherry picked from commit 68f6578adcd84598a6ce253f33e1c46c9a6b50ea)