coverage job fails even without any code changes

[Goutham Pacha Ravi]

The coverage test (tox -e cover) sometimes fails even without any code changes being committed.

Example Failure: http://logs.openstack.org/32/609832/2/check/openstack-tox-cover/1443a75/
Review in question: https://review.openstack.org/#/c/609832/
Console Log file attached with this report.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/609832
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=a07c51e8b01074d8ee8bb936a31ad4c1654c4e73
Submitter: Zuul
Branch: master

commit a07c51e8b01074d8ee8bb936a31ad4c1654c4e73
Author: Goutham Pacha Ravi <email address hidden>
Date: Thu Oct 11 15:00:07 2018 -0700

    Make coverage non-voting and fix use of rpc_backend

    rpc_backend was an old oslo_messaging option
    that was deprecated in stable/newton and removed
    in master/stein [2], so stop using it in our
    unit tests.

    The coverage job in manila was always non-voting,
    however, a773e31420bfd141682c43d0823d2009078c2fec
    added a common coverage job-template from the
    openstack-zuul-jobs repository. This change
    inadvertently made the non-voting cover job a
    voting job.

    Our coverage script isn't perfect, it is known
    to fail erroneously on non-code changes, and
    some genuine failures are just an indication
    to developers and reviewers to make the best
    effort to adhere to the script's strict
    checks [3].

    These changes are unrelated, but must be fixed
    together to pass the gate, since we have a
    chicken-and-egg problem with both failures
    preventing separate fixes from merging
    separately.

    [1] https://review.openstack.org/#/c/317285/
    [2] https://review.openstack.org/#/c/580910/
    [3] http://git.openstack.org/cgit/openstack/manila/tree/tools/cover.sh

    Closes-Bug: #1796759
    Related-Bug: #1797512
    Change-Id: Ie349c3866d51ea4e706369ad67bc1155f62f2651

[Jason Grosso (jgrosso)]

since the job is non-voting, reviewers may take a call to ignore coverage failure

[Vida Haririan (vhariria)]

Is this still an issue?

[Vida Haririan (vhariria)]

Additional comments are at https://meetings.opendev.org/meetings/manila/2024/manila.2024-01-04-15.00.log.html

[Launchpad Janitor (janitor)]

[Expired for OpenStack Shared File Systems Service (Manila) because there has been no activity for 60 days.]