OpenStack Shared File Systems Service (Manila)

run_tests.sh fails with invalid command testr

Bug #1790470 reported by Maurice Escher on 2018-09-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Shared File Systems Service (Manila)	Fix Released	Low	Tom Barron	OpenStack Shared File Systems Service (Manila) stein-1

Bug Description

Hi,

I want to run the unit tests in stable/rocky 'run_tests.sh -V', but it seems the removal of testrepository in https://github.com/openstack/manila/commit/e8bca58887880b53ab61810a414ba8d5c5643c5c stopped the script from working.

It worked in pike, I cannot say about queens - I skipped this release.

BR,
Maurice

Tags:

Revision history for this message

Ben Swartzlander (bswartz) wrote on 2018-09-27:

It's past time that we removed run_tests.sh. The replacement is tox. People should use that.

Tom Barron (tpb) on 2018-09-27

Changed in manila:
status:	New → Won't Fix

Revision history for this message

Maurice Escher (maurice-escher) wrote on 2018-09-28:

Isn't the fix then removing it and adjusting the docs https://docs.openstack.org/manila/rocky/contributor/unit_tests.html?

Revision history for this message

Tom Barron (tpb) wrote on 2018-09-28:

@Maurice: Fair point, I'll take this bug and do the cleanup you indicate.

Changed in manila:
importance:	Undecided → Low
status:	Won't Fix → Confirmed
assignee:	nobody → Tom Barron (tpb)
milestone:	none → stein-1
tags:	added: tests

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-03: Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/607724

Changed in manila:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-04: Fix merged to manila (master)

Reviewed: https://review.openstack.org/607724
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=772a64a8717461495cc3a26d49f9fb848a61edf2
Submitter: Zuul
Branch: master

commit 772a64a8717461495cc3a26d49f9fb848a61edf2
Author: Tom Barron <email address hidden>
Date: Wed Oct 3 17:32:55 2018 -0400

Remove run_tests.sh

It is deprecated in favor of tox.

Closes-Bug: #1790470
Change-Id: If3b6a274dab0d035b9666b3b9876604cefbc2877

Changed in manila:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-05: Fix proposed to manila (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/608233

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-16: Fix merged to manila (stable/rocky)

Reviewed: https://review.openstack.org/608233
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ec8c500f176d33d55e9d19d330e65366e025c666
Submitter: Zuul
Branch: stable/rocky

commit ec8c500f176d33d55e9d19d330e65366e025c666
Author: Tom Barron <email address hidden>
Date: Wed Oct 3 17:32:55 2018 -0400

Remove run_tests.sh

It is deprecated in favor of tox.

    Closes-Bug: #1790470
    Change-Id: If3b6a274dab0d035b9666b3b9876604cefbc2877
    (cherry picked from commit 772a64a8717461495cc3a26d49f9fb848a61edf2)

tags:

added: in-stable-rocky

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-16: Fix proposed to manila (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/610984

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-17: Fix merged to manila (stable/queens)

Reviewed: https://review.openstack.org/610984
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=66105f93e3855282cc9758f72f5c2d4fc00e6a21
Submitter: Zuul
Branch: stable/queens

commit 66105f93e3855282cc9758f72f5c2d4fc00e6a21
Author: Tom Barron <email address hidden>
Date: Wed Oct 3 17:32:55 2018 -0400

Remove run_tests.sh

It is deprecated in favor of tox.

    Closes-Bug: #1790470
    Change-Id: If3b6a274dab0d035b9666b3b9876604cefbc2877
    (cherry picked from commit 772a64a8717461495cc3a26d49f9fb848a61edf2)
    (cherry picked from commit ec8c500f176d33d55e9d19d330e65366e025c666)