OpenStack Shared File Systems Service (Manila)

Log formatters set up incorrectly in devstack

Bug #1787310 reported by Goutham Pacha Ravi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Goutham Pacha Ravi

Bug Description

The log formatters in the manila devstack plugin mess up logging by inserting two time stamps. This affects any log coloring intended, and parsing logs to apply filters based on LOG line category, as in the gate jobs [2]

For example, consider the log file here (also attached to this bug) :

http://logs.openstack.org/56/586456/4/check/manila-tempest-minimal-dsvm-dummy/c0f75cb/logs/screen-m-shr.txt.gz

[1] https://github.com/openstack/manila/blob/f9ae7aa/devstack/plugin.sh#L270

[2] https://github.com/openstack-infra/os-loganalyze

Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :
Changed in manila:
importance: Undecided → Medium
assignee: nobody → Goutham Pacha Ravi (gouthamr)
OpenStack Infra (hudson-openstack)
Changed in manila:
status: New → In Progress
Goutham Pacha Ravi (gouthamr)
summary: - Log formatters set logging up incorrectly in devstack
+ Log formatters set up incorrectly in devstack
tags: added: pike-backport-potential qocky-backport-potential queens-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/588855
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=9448c3360dd8e2378ec73a3d695bb7b350a32e05
Submitter: Zuul
Branch: master

commit 9448c3360dd8e2378ec73a3d695bb7b350a32e05
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Aug 15 17:12:50 2018 -0700

    Remove logging overrides from plugin.sh

    Avoid overwriting the log formatters, reuse
    the helper available in Devstack.

    Closes-Bug: #1787310
    Change-Id: I25eb16ea9a6e3e98de6a7ee349df17438847d601

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/592787

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/rocky)

Reviewed: https://review.openstack.org/592787
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=b1d0067159047ecc0503575af11cd5a4969c286d
Submitter: Zuul
Branch: stable/rocky

commit b1d0067159047ecc0503575af11cd5a4969c286d
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Aug 15 17:12:50 2018 -0700

    Remove logging overrides from plugin.sh

    Avoid overwriting the log formatters, reuse
    the helper available in Devstack.

    Closes-Bug: #1787310
    Change-Id: I25eb16ea9a6e3e98de6a7ee349df17438847d601
    (cherry picked from commit 9448c3360dd8e2378ec73a3d695bb7b350a32e05)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/603990

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/604033

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/queens)

Reviewed: https://review.openstack.org/604033
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=b2b9bf5baf2ab0ebd596f134d3655f63cddd3aa3
Submitter: Zuul
Branch: stable/queens

commit b2b9bf5baf2ab0ebd596f134d3655f63cddd3aa3
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Aug 15 17:12:50 2018 -0700

    Remove logging overrides from plugin.sh

    Avoid overwriting the log formatters, reuse
    the helper available in Devstack.

    Closes-Bug: #1787310
    Change-Id: I25eb16ea9a6e3e98de6a7ee349df17438847d601
    (cherry picked from commit 9448c3360dd8e2378ec73a3d695bb7b350a32e05)
    (cherry picked from commit b1d0067159047ecc0503575af11cd5a4969c286d)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/pike)

Reviewed: https://review.openstack.org/603990
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=2ba3a268e7fc24a7b9b72745bd14f7a16f8cd17e
Submitter: Zuul
Branch: stable/pike

commit 2ba3a268e7fc24a7b9b72745bd14f7a16f8cd17e
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Aug 15 17:12:50 2018 -0700

    Remove logging overrides from plugin.sh

    Avoid overwriting the log formatters, reuse
    the helper available in Devstack.

    Closes-Bug: #1787310
    Change-Id: I25eb16ea9a6e3e98de6a7ee349df17438847d601
    (cherry picked from commit 9448c3360dd8e2378ec73a3d695bb7b350a32e05)
    (cherry picked from commit b1d0067159047ecc0503575af11cd5a4969c286d)
    (cherry picked from commit b2b9bf5baf2ab0ebd596f134d3655f63cddd3aa3)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/604484

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/ocata)

Reviewed: https://review.openstack.org/604484
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f4f960b9acc6a7ee5a39a0bf41af86bb14bbaff1
Submitter: Zuul
Branch: stable/ocata

commit f4f960b9acc6a7ee5a39a0bf41af86bb14bbaff1
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed Aug 15 17:12:50 2018 -0700

    Remove logging overrides from plugin.sh

    Avoid overwriting the log formatters, reuse
    the helper available in Devstack.

    Closes-Bug: #1787310
    Change-Id: I25eb16ea9a6e3e98de6a7ee349df17438847d601
    (cherry picked from commit 9448c3360dd8e2378ec73a3d695bb7b350a32e05)
    (cherry picked from commit b1d0067159047ecc0503575af11cd5a4969c286d)
    (cherry picked from commit b2b9bf5baf2ab0ebd596f134d3655f63cddd3aa3)
    (cherry picked from commit 2ba3a268e7fc24a7b9b72745bd14f7a16f8cd17e)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 4.0.2

This issue was fixed in the openstack/manila 4.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 5.0.2

This issue was fixed in the openstack/manila 5.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 7.1.0

This issue was fixed in the openstack/manila 7.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.1.0

This issue was fixed in the openstack/manila 6.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 8.0.0.0rc1

This issue was fixed in the openstack/manila 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.