ZFSonLinux driver fails to manage share in scenario test

Bug #1785180 reported by Nir Gilboa on 2018-08-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Manila
Medium
Goutham Pacha Ravi

Bug Description

While testing a new scenario test as specified here:
http://specs.openstack.org/openstack/manila-specs/specs/release_independent/scenario-tests.html#create-manage-share-and-write-data

After being successfully unmanaged, the manage operation fails:
http://logs.openstack.org/95/545695/18/check/manila-tempest-dsvm-postgres-zfsonlinux/8e1b69e/logs/screen-m-shr.txt.gz#_Jul_30_07_45_00_563569

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/server.py", line 163, in _process_incoming
    res = self.dispatcher.dispatch(message)
  File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 265, in dispatch
    return self._do_dispatch(endpoint, method, ctxt, args)
  File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 194, in _do_dispatch
    result = func(ctxt, **new_args)
  File "/opt/stack/new/manila/manila/share/manager.py", line 187, in wrapped
    return f(self, *args, **kwargs)
  File "/opt/stack/new/manila/manila/utils.py", line 571, in wrapper
    return func(self, *args, **kwargs)
  File "/opt/stack/new/manila/manila/share/manager.py", line 2379, in manage_share
    self.driver.manage_existing(share_instance, driver_options)
  File "/opt/stack/new/manila/manila/share/drivers/zfsonlinux/driver.py", line 769, in manage_existing
    self.zfs("mount", new_dataset_name)
  File "/opt/stack/new/manila/manila/share/drivers/zfsonlinux/utils.py", line 145, in zfs
    return self.execute('sudo', 'zfs', *cmd, **kwargs)
  File "/opt/stack/new/manila/manila/share/drivers/zfsonlinux/utils.py", line 97, in execute
    return executor(*cmd, **kwargs)
  File "/opt/stack/new/manila/manila/share/drivers/ganesha/utils.py", line 79, in __call__
    ret = processutils.ssh_execute(ssh, cmd, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py", line 570, in ssh_execute
    cmd=sanitized_cmd)
ProcessExecutionError: Unexpected error while running command.
Command: sudo zfs mount gamma/manila_share_aaddcd5b_906c_4b22_8257_e6b377a56e63
Exit code: 1
Stdout: u''
Stderr: u"cannot mount 'gamma/manila_share_aaddcd5b_906c_4b22_8257_e6b377a56e63': filesystem already mounted\n"

Tom Barron (tpb) on 2018-08-03
tags: added: zfsonlinux
Changed in manila:
importance: Undecided → Medium
status: New → Confirmed

Fix proposed to branch: master
Review: https://review.openstack.org/588667

Changed in manila:
assignee: nobody → Goutham Pacha Ravi (gouthamr)
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/588667
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=d7c01efb444b7bf02c1729be3554abebaee473a3
Submitter: Zuul
Branch: master

commit d7c01efb444b7bf02c1729be3554abebaee473a3
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Aug 3 14:46:08 2018 -0700

    [ZFSOnLinux] Retry unmounting old datasets during manage

    Add a retry loop to ensure the dataset being renamed
    is cleanly unmounted before the rename operation.

    Change-Id: Ie506f237010c415ee9f0d64abbefd5854f776a5f
    Closes-Bug: #1785180

Changed in manila:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/591815
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6d8f47d3c367aa0247dca713146825cfa66b6848
Submitter: Zuul
Branch: stable/rocky

commit 6d8f47d3c367aa0247dca713146825cfa66b6848
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Aug 3 14:46:08 2018 -0700

    [ZFSOnLinux] Retry unmounting old datasets during manage

    Add a retry loop to ensure the dataset being renamed
    is cleanly unmounted before the rename operation.

    Change-Id: Ie506f237010c415ee9f0d64abbefd5854f776a5f
    Closes-Bug: #1785180
    (cherry picked from commit d7c01efb444b7bf02c1729be3554abebaee473a3)

tags: added: in-stable-rocky

Reviewed: https://review.openstack.org/604477
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=820638ccef471eb00f2a233e64b05a9c377e170c
Submitter: Zuul
Branch: stable/queens

commit 820638ccef471eb00f2a233e64b05a9c377e170c
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Aug 3 14:46:08 2018 -0700

    [ZFSOnLinux] Retry unmounting old datasets during manage

    Add a retry loop to ensure the dataset being renamed
    is cleanly unmounted before the rename operation.

    Change-Id: Ie506f237010c415ee9f0d64abbefd5854f776a5f
    Closes-Bug: #1785180
    (cherry picked from commit d7c01efb444b7bf02c1729be3554abebaee473a3)
    (cherry picked from commit 6d8f47d3c367aa0247dca713146825cfa66b6848)

tags: added: in-stable-queens

Reviewed: https://review.openstack.org/605050
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=efbc62d9b29e94dd45339fa78da93a6a85532271
Submitter: Zuul
Branch: stable/pike

commit efbc62d9b29e94dd45339fa78da93a6a85532271
Author: Goutham Pacha Ravi <email address hidden>
Date: Fri Aug 3 14:46:08 2018 -0700

    [ZFSOnLinux] Retry unmounting old datasets during manage

    Add a retry loop to ensure the dataset being renamed
    is cleanly unmounted before the rename operation.

    Change-Id: Ie506f237010c415ee9f0d64abbefd5854f776a5f
    Closes-Bug: #1785180
    (cherry picked from commit d7c01efb444b7bf02c1729be3554abebaee473a3)
    (cherry picked from commit 6d8f47d3c367aa0247dca713146825cfa66b6848)
    (cherry picked from commit 820638ccef471eb00f2a233e64b05a9c377e170c)

tags: added: in-stable-pike

This issue was fixed in the openstack/manila 5.0.2 release.

This issue was fixed in the openstack/manila 7.1.0 release.

This issue was fixed in the openstack/manila 6.1.0 release.

This issue was fixed in the openstack/manila 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers