OpenStack Shared File Systems Service (Manila)

Cannot reload configuration in manila-scheduler

Bug #1785129 reported by Goutham Pacha Ravi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Tom Barron
OpenStack Shared File Systems Service (Manila) rocky-3 "R-3"

Bug Description

Mutable configuration was introduced to manila in [1]. However, the scheduler process ignores any SIGHUP sent to it.

RCA:
The manila-scheduler process does not use the ProcessLauncher that we fixed up in [1]. It uses service.launch()

[1] https://review.openstack.org/#/c/504321/

Goutham Pacha Ravi (gouthamr)
Changed in manila:
importance: Undecided → Medium
assignee: nobody → sajuptpm (sajuptpm)
milestone: none → rocky-3
OpenStack Infra (hudson-openstack)
Changed in manila:
assignee: sajuptpm (sajuptpm) → Tom Barron (tpb)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/585890
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=9da534344a9b8790c88378816db1c1fc378b2a59
Submitter: Zuul
Branch: master

commit 9da534344a9b8790c88378816db1c1fc378b2a59
Author: Saju.Madhavan <email address hidden>
Date: Thu Jul 26 02:46:17 2018 +0530

    Fix mutable config in manila-scheduler

    We had SIGHUP apply the "mutate" behavior to the
    ProcessLauncher with [1], however, the scheduler
    process does not use ProcessLauncher.

    Oslo config made "debug" a mutable config option
    in [3]

    Closes-Bug: #1785129

    [1] I6499ae6c98d9489a123bb20febd6c1ddb9e17b86
    [3] I1e7a69de169cc85f4c09954b2f46ce2da7106d90

    Change-Id: Ifffe3cad0f5cd52988ce253794efc5b03ea9840b

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/588854

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/queens)

Reviewed: https://review.openstack.org/588854
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ef6b5c335f1dd9551d040eeddeb665052ae88e71
Submitter: Zuul
Branch: stable/queens

commit ef6b5c335f1dd9551d040eeddeb665052ae88e71
Author: Saju.Madhavan <email address hidden>
Date: Thu Jul 26 02:46:17 2018 +0530

    Fix mutable config in manila-scheduler

    We had SIGHUP apply the "mutate" behavior to the
    ProcessLauncher with [1], however, the scheduler
    process does not use ProcessLauncher.

    Oslo config made "debug" a mutable config option
    in [3]

    Closes-Bug: #1785129

    [1] I6499ae6c98d9489a123bb20febd6c1ddb9e17b86
    [3] I1e7a69de169cc85f4c09954b2f46ce2da7106d90

    Change-Id: Ifffe3cad0f5cd52988ce253794efc5b03ea9840b
    (cherry picked from commit 9da534344a9b8790c88378816db1c1fc378b2a59)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/589709

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (stable/pike)

Change abandoned by Goutham Pacha Ravi (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/589709
Reason: https://review.openstack.org/#/c/504321/ was only introduced in Queens, doesn't need a backport to stable/pike

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 7.0.0.0rc1

This issue was fixed in the openstack/manila 7.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.1.0

This issue was fixed in the openstack/manila 6.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.