manila scheduler does not filter storage protocol

[liushi]

I found that the current manila scheduler does not filter the storage protocol during scheduling, which I think is unreasonable. If the user has multiple share backends that provide storage support for different protocols, this will not allow the user to reasonably use the storage protocol to specify the storage backend.

In my environment, there is only one cephfs backend, but I specified in the API to enable the CIFS protocol, this create operation will still be scheduler to cephfs, I think this should be thrown by the `manila-scheduler` NoValidHost exception.

Maybe we should filter the drive in `manila.scheduler.filters.driver.DriverFilter:host_passes`

// manila.conf
```ini
[DEFAULT]
enabled_share_protocols = CEPHFS, NFS, CIFS
enabled_share_backends = cephfs-001

[cephfs-001]
share_backend_name = ctest-ssd
share_driver = manila.share.drivers.cephfs.cephfs_native.CephFSNativeDriver
```

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/586456

[Goutham Pacha Ravi (gouthamr)]

Picking this bug up since it's still a valid concern in manila.

It is possible to reproduce this issue the way the description says:

- In a manila environment, enable a random protocol by appending to "[DEFAULT]/enabled_share_protocols" E.g.:

       [DEFAULT]
       ...
       enabled_share_protocols = NFS, CIFS, INVALIDPROTOCOL

- Create a share with "INVALIDPROTOCOL"
- curl -i -X POST http://<MANILA-ENDPOINT>/v2/<PROJECT-ID>/shares -H "X-Auth-Token: <AUTH_TOKEN>" -H "X-Openstack-Manila-Api-Version: 2.51" -d '{"share": {"size": 1, "snapshot_id": null, "name": null, "description": null, "metadata": {}, "share_proto": "INVALIDPROTOCOL", "share_network_id": null, "share_type": null, "is_public": false, "availability_zone": null}}'

This request will be accepted, and the share goes to error state after the manila-scheduler is done with it.

[Goutham Pacha Ravi (gouthamr)]

Fix proposed to branch: master
    https://review.opendev.org/781026

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 12.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/783206
Committed: https://opendev.org/openstack/manila/commit/06d380c212006346b350b386906089d2f5fd2468
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 06d380c212006346b350b386906089d2f5fd2468
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Mar 16 23:48:42 2021 -0700

    Filter storage protocol in the scheduler

    The share protocol requested was being
    ignored by the scheduler and this would
    cause shares to get scheduled to hosts
    that don't support the specified protocol.

    Change-Id: I2e87264865b645781c481383c039fecbfd7c6eb1
    Closes-Bug: #1783736
    (cherry picked from commit f24fff9522a114d88406e820e2cac5d14398a6c1)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/manila/+/792765

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/792765
Committed: https://opendev.org/openstack/manila/commit/4a75c699c0cb36757c56a14dddf3cd83497dc33a
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 4a75c699c0cb36757c56a14dddf3cd83497dc33a
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Mar 16 23:48:42 2021 -0700

    Filter storage protocol in the scheduler

    The share protocol requested was being
    ignored by the scheduler and this would
    cause shares to get scheduled to hosts
    that don't support the specified protocol.

    Change-Id: I2e87264865b645781c481383c039fecbfd7c6eb1
    Closes-Bug: #1783736
    (cherry picked from commit f24fff9522a114d88406e820e2cac5d14398a6c1)
    (cherry picked from commit 06d380c212006346b350b386906089d2f5fd2468)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/manila/+/794055

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Goutham Pacha Ravi <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/manila/+/586456
Reason: Thank you for proposing this fix, as noted on the bug report, we've decided to take a different direction. The fix is being back-ported to stable branches: https://review.opendev.org/q/topic:%22bug%252F1783736%22+(status:open%20OR%20status:merged)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/794055
Committed: https://opendev.org/openstack/manila/commit/4bf36d02297cb78f0af2221891e563c4fb844a5c
Submitter: "Zuul (22348)"
Branch: stable/train

commit 4bf36d02297cb78f0af2221891e563c4fb844a5c
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Mar 16 23:48:42 2021 -0700

    Filter storage protocol in the scheduler

    The share protocol requested was being
    ignored by the scheduler and this would
    cause shares to get scheduled to hosts
    that don't support the specified protocol.

    Change-Id: I2e87264865b645781c481383c039fecbfd7c6eb1
    Closes-Bug: #1783736
    (cherry picked from commit f24fff9522a114d88406e820e2cac5d14398a6c1)
    (cherry picked from commit 06d380c212006346b350b386906089d2f5fd2468)
    (cherry picked from commit 4a75c699c0cb36757c56a14dddf3cd83497dc33a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 10.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 11.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila train-eol release.