OpenStack Shared File Systems Service (Manila)

all_tenants value is not handled correctly

Bug #1777551 reported by jiaopengju
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
jiaopengju
OpenStack Shared File Systems Service (Manila) stein-rc1

Bug Description

Currently in Manila share list API[1], network list API and security list API, the value of all_tenants is not handled which is not same as the description of the API documentation, for example, in share list API it is described as '(Admin only). Defines whether to list shares or share groups for all tenants. Set to 1 to list shares or sharegroups for all tenants. Set to 0 to list shares or share groups only for the current tenant.'

But actually, when we add all_tenants to the url path, no matter what value it is, the api always return all the shares of all tenants.

[1] https://developer.openstack.org/api-ref/shared-file-system/#list-shares

See original description
jiaopengju (pj-jiao)
Changed in manila:
assignee: nobody → jiaopengju (pj-jiao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/576332

jiaopengju (pj-jiao)
description: updated
Tom Barron (tpb)
Changed in manila:
milestone: none → rocky-3
Dustin Schoenbrun (dschoenb)
Changed in manila:
status: New → In Progress
importance: Undecided → Medium
OpenStack Infra (hudson-openstack)
Changed in manila:
assignee: jiaopengju (pj-jiao) → xulei (605423512-j)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/576332
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3eceed017bef43ef38f49b83a7f629cd1342ace5
Submitter: Zuul
Branch: master

commit 3eceed017bef43ef38f49b83a7f629cd1342ace5
Author: xulei <email address hidden>
Date: Tue Jun 19 13:22:08 2018 +0800

    check all_tenants value in share api

    add manila.utils.is_all_tenants to check all_tenants value.
    share_networks and security_service api will check all_tenants value
    in the following patches.

    Change-Id: I1aa9903276038dc839df45b852b329a75be5657f
    Partial-Bug: #1777551
    Co-Authored-By: Jiao Pengju <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/588853

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/queens)

Reviewed: https://review.openstack.org/588853
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=2eb7636f03c275ba544f3aba23674824d4597ba8
Submitter: Zuul
Branch: stable/queens

commit 2eb7636f03c275ba544f3aba23674824d4597ba8
Author: xulei <email address hidden>
Date: Tue Jun 19 13:22:08 2018 +0800

    check all_tenants value in share api

    add manila.utils.is_all_tenants to check all_tenants value.
    share_networks and security_service api will check all_tenants value
    in the following patches.

    Change-Id: I1aa9903276038dc839df45b852b329a75be5657f
    Partial-Bug: #1777551
    Co-Authored-By: Jiao Pengju <email address hidden>
    (cherry picked from commit 3eceed017bef43ef38f49b83a7f629cd1342ace5)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/618991

Changed in manila:
assignee: xulei (605423512-j) → hulina (sharonhu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/619401

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by hulina (<email address hidden>) on branch: master
Review: https://review.openstack.org/619401

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/620197

Changed in manila:
assignee: hulina (sharonhu) → zhangqing (zhang-qing)
Tom Barron (tpb)
Changed in manila:
milestone: rocky-3 → none
OpenStack Infra (hudson-openstack)
Changed in manila:
assignee: zhangqing (zhang-qing) → Goutham Pacha Ravi (gouthamr)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/620197
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=bb8859f8ac22562dc2847d3ef228b8f2a3261d1b
Submitter: Zuul
Branch: master

commit bb8859f8ac22562dc2847d3ef228b8f2a3261d1b
Author: zhangqing <email address hidden>
Date: Mon Nov 26 10:01:07 2018 +0800

    Check all_tenants value in security_service api

    Add manila.utils.is_all_tenants to check all_tenants value.

    Partial-Bug: #1777551
    Co-Authored-By: Yu Weizhong <email address hidden>
    Change-Id: I1c8068cb0d4652f1f0349dc5a8d0a2d3af2318e0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/618991
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=34356e73b92655af78034d4b6e3eff438b437ec1
Submitter: Zuul
Branch: master

commit 34356e73b92655af78034d4b6e3eff438b437ec1
Author: hulina <email address hidden>
Date: Tue Nov 20 19:34:07 2018 +0800

    Check all_tenants value in share_networks api

    Add manila.utils.is_all_tenants to check all_tenants value.

    Closes-Bug: #1777551
    Change-Id: I1b66a25169cdd23a76bf76c799d04521fdf5f8e9

Changed in manila:
status: In Progress → Fix Released
Goutham Pacha Ravi (gouthamr)
Changed in manila:
milestone: none → stein-rc1
assignee: Goutham Pacha Ravi (gouthamr) → jiaopengju (pj-jiao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 8.0.0.0rc1

This issue was fixed in the openstack/manila 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.