Mutable default argument in Quobyte Manila driver

Bug #1773929 reported by Silvan Kaiser on 2018-05-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Undecided
Silvan Kaiser

Bug Description

A review in https://review.openstack.org/#/c/570741/1 points out a mutable default argument in the Quobyte driver that should be handled more stably.

Silvan Kaiser (2-silvan) on 2018-05-29
Changed in manila:
assignee: nobody → Silvan Kaiser (2-silvan)
Changed in manila:
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/572291

Reviewed: https://review.openstack.org/572291
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=5deab9b9cf82ebc897547d2d29b99b7228659aec
Submitter: Zuul
Branch: master

commit 5deab9b9cf82ebc897547d2d29b99b7228659aec
Author: Silvan Kaiser <email address hidden>
Date: Tue Jun 5 10:07:08 2018 +0200

    Fix mutable default argument in Quobyte jsonrpc

    Change-Id: I03d86c45aed3238cfa82de3eea5bc44c285cc118
    Closes-Bug: #1773929

Changed in manila:
status: In Progress → Fix Released

This issue was fixed in the openstack/manila 7.0.0.0b3 development milestone.

Reviewed: https://review.openstack.org/570556
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=bbf8864fe16aaee1e19d3fb8759188d188667037
Submitter: Zuul
Branch: master

commit bbf8864fe16aaee1e19d3fb8759188d188667037
Author: Silvan Kaiser <email address hidden>
Date: Tue Jun 5 10:07:08 2018 +0200

    Adds export path option to Quobyte driver

    A new option for configuring the export path of
    shares provided by the Quobyte driver is added.
    This allows adapting the export path to the settings
    of the Quobyte NFS servers 'Pseudo' option.

    Besides the new option this also fixes a minor
    coding style issue regarding a mutable default
    argument in jsonrpc.py.

    Implements: blueprint qb-export-path-option
    Closes-Bug: #1773929

    Change-Id: Ibd486c8418469045a0988ef66a1c5cef810d3eae

Reviewed: https://review.openstack.org/613951
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=d5ff8bb94929fa4cbd9c7367b43030e13f415f74
Submitter: Zuul
Branch: stable/queens

commit d5ff8bb94929fa4cbd9c7367b43030e13f415f74
Author: Silvan Kaiser <email address hidden>
Date: Tue Jun 5 10:07:08 2018 +0200

    Fix mutable default argument in Quobyte jsonrpc

    Change-Id: I03d86c45aed3238cfa82de3eea5bc44c285cc118
    Closes-Bug: #1773929
    (cherry picked from commit 5deab9b9cf82ebc897547d2d29b99b7228659aec)

tags: added: in-stable-queens

This issue was fixed in the openstack/manila 6.1.0 release.

This issue was fixed in the openstack/manila 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers