LVM driver does not handle IPv6 addresses in recovery mode

Bug #1746723 reported by Rodrigo Barbieri on 2018-02-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
High
Rodrigo Barbieri

Bug Description

The recovery mode is using when Share Migration needs to convert rules to read-only. Thus, all rules are removed and re-added in read-only mode. For that, drivers have a "recovery mode" code path in update_access.

Although the recovery mode in the LVM driver is fairly inefficient (it removes each rule instead of just setting the list of rules according to the list of rules that the share should have), it attempts to perform the removal step without parsing IPv6 addresses, causing errors in this code path and preventing migration to run when IPv6 addresses are used. This can be seen in: https://github.com/openstack/manila/blob/81e708281f6bdeea2dba12eb08cf9c33265e7050/manila/share/drivers/helpers.py#L245

The correct behavior should be that the function "_get_parsed_address_or_cidr" is invoked to parse the address, as it is done for the other code paths. This function can be found in the same file: https://github.com/openstack/manila/blob/81e708281f6bdeea2dba12eb08cf9c33265e7050/manila/share/drivers/helpers.py#L308

Changed in manila:
milestone: none → queens-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/541807

Changed in manila:
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
status: New → In Progress
Changed in manila:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/541807
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=73ef94d38fcf28d6de5133db662b19e06d86fde7
Submitter: Zuul
Branch: master

commit 73ef94d38fcf28d6de5133db662b19e06d86fde7
Author: Rodrigo Barbieri <email address hidden>
Date: Wed Feb 7 13:36:26 2018 -0200

    Fix LVM driver not handling IPv6 in recovery mode

    Recovery mode is currently used by host-assisted share
    migration to bulk remove and add back rules while casting
    them to read only.

    Unfortunately, it is not handling IPv6 addresses when removing
    the rules in this code path. This patch adds a call to a function
    that handles the IPv6 addresses, adding brackets around them.

    Change-Id: Icba4b22ad87ccfabcc02078648b1abc6410e5353
    Closes-bug: #1746723

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.0.0.0rc1

This issue was fixed in the openstack/manila 6.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers