INFINIDAT share driver fails to delete shares with snapshots

Bug #1746439 reported by Amit Oren on 2018-01-31
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Undecided
Amit Oren

Bug Description

To reproduce the bug:

* Through the Manila interface, create a share on an INFINIDAT InfiniBox system.
* Through the InfiniBox interface (out of Manila), create a snapshot for the newly created share
* Try to delete the share through Manila. The deletion will fail since the share has externally created snapshots (not managed through Manila).

The bug lies in the delete_share implementation in the INFINIDAT share driver, specifically:
https://github.com/openstack/manila/blob/a07d5229704841d5a8a6333b375ece4b6e0f9269/manila/share/drivers/infinidat/infinibox.py#L334

To fix the bug:
The check for the share's children should be removed; we should try to delete the share anyway.

Changed in manila:
assignee: nobody → Amit Oren (amito)
status: New → In Progress
Amit Oren (amito) on 2018-01-31
summary: - INFINIDAT share driver fails to delete shares with snapshots
+ INFINIDAT share driver fails to delete datasets with snapshots
summary: - INFINIDAT share driver fails to delete datasets with snapshots
+ INFINIDAT share driver fails to delete shares with snapshots
Changed in manila:
milestone: none → queens-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/538617
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=09da8f8d9ddbb27b73aba39f6002a1b5718ac555
Submitter: Zuul
Branch: master

commit 09da8f8d9ddbb27b73aba39f6002a1b5718ac555
Author: Amit Oren <email address hidden>
Date: Sun Jan 28 16:25:16 2018 +0200

    INFINIDAT: support deleting datasets with snapshots

    Deleting a share or a snapshot from the INFINDIAT InfiniBox should
    support a case where the share or snapshot has snapshots that were
    created externally (i.e. through the InfiniBox interface).

    Change-Id: Ic9d03493283c573506330a620fa21516bbd09c26
    Closes-Bug: #1746439

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.0.0.0rc1

This issue was fixed in the openstack/manila 6.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers