Host assisted Share Migration breaks on IPv4+IPv6 backends

[Rodrigo Barbieri]

As of Queens-3 Milestone, the Host-assisted Share migration is unable to handle a combination of source and destination backends where:

1) one backend has IPv4 and IPv6 export locations
2) one backend has IPv4 and the other has IPv6 export locations

The reason for this is that the config 'data_node_access_ip' found in the Data Service only supports one IP. The IP set here can be either IPv4 or IPv6, but cannot be both. In other words, the Host-assisted Share Migration could only handle IPv4-only or IPv6-only combinations of source and destination backends.

When attempting to migrate a share which has IPv6 export locations, while the 'data_node_access_ip' config option value is IPv4 (or vice-versa) results in the Data Service failing to mount the share, as it allows access to the IPv4 set in 'data_node_access_ip', not the IPv6 needed to mount the share.

Commit 11c45641befef028f4fac76381616d26a78b4ed0, which enabled IPv6 tests on Upstream CI, temporarily disabled IPv6 support for the Host-assisted Share Migration, so only IPv4 addresses are accepted. The functionality of migrating between IPv6-only backends has been lost.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/541478

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/541478
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=53ec28a1caa2555917974c8e0eb0efffdf58dfdb
Submitter: Zuul
Branch: master

commit 53ec28a1caa2555917974c8e0eb0efffdf58dfdb
Author: Rodrigo Barbieri <email address hidden>
Date: Thu Feb 1 17:08:41 2018 -0200

    Fix Host-assisted Share Migration with IPv4+IPv6

    Previously, the Data Service allowed only 1 IP to be specified
    for the 'data_node_access_ip' config option, which prevented
    Host-assisted Share Migration to be successful on a combination
    of backends that include IPv6 and IPv4 export locations.

    To fix this, we are adding a new config option and deprecating
    the old one. The new one is named 'data_node_access_ips' and
    accepts a list of IPs. All IPs included in this list should
    correspond to interfaces on the node running the Data Service
    and will be allowed access during Host-assisted Share Migration.

    Additionally, we are improving the responsiveness of the
    Host-assisted Share Migration by using exponential waiters
    instead of polynomial. Those waiters are used when managing
    resources created by Share Migration.

    Closes-bug: #1745436
    Partial-bug: #1708491

    Change-Id: I1c0b7621ae8192f75f691987b185a4fc6a7228ce

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 6.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/673672

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/673672
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=9551623c22f86b069119a2e02c6dda326a0cf19f
Submitter: Zuul
Branch: master

commit 9551623c22f86b069119a2e02c6dda326a0cf19f
Author: Goutham Pacha Ravi <email address hidden>
Date: Tue Jul 30 12:54:57 2019 -0700

    Remove support for ``data_node_access_ip``

    It was deprecated in the Queens release, in
    favor of ``data_node_access_ips``.

    Change-Id: I01f24c2e0d66e1da4c30c579c02afc8f3930c8f8
    Related-Bug: #1745436