is_default value is always empty after creating a type/group type

Bug #1743941 reported by junboli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Goutham Pacha Ravi
python-manilaclient
Fix Released
Medium
Goutham Pacha Ravi

Bug Description

Currently, when we create a type or group type, the value of is_default is always empty, e.g.

$ manila type-create default 1
+----------------------+--------------------------------------+
| Property | Value |
+----------------------+--------------------------------------+
| required_extra_specs | driver_handles_share_servers : True |
| Name | default |
| Visibility | public |
| is_default | - |
| ID | d44a0a90-a5c7-410e-85b1-58d25b06ff16 |
| optional_extra_specs | |
+----------------------+--------------------------------------+

the right result should be:

$ manila type-create default 1
+----------------------+--------------------------------------+
| Property | Value |
+----------------------+--------------------------------------+
| required_extra_specs | driver_handles_share_servers : True |
| Name | default |
| Visibility | public |
| is_default | YES |
| ID | d44a0a90-a5c7-410e-85b1-58d25b06ff16 |
| optional_extra_specs | |
+----------------------+--------------------------------------+

The same issue goes to share-group-type-create command.

junboli (junboli)
Changed in python-manilaclient:
assignee: nobody → junboli (junboli)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/535178

Changed in python-manilaclient:
status: New → In Progress
Changed in manila:
status: New → Confirmed
assignee: nobody → junboli (junboli)
milestone: none → rocky-3
importance: Undecided → Medium
Changed in python-manilaclient:
importance: Undecided → Medium
Tom Barron (tpb)
Changed in python-manilaclient:
milestone: none → rocky-3
Changed in manila:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila-tempest-plugin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/582819

Changed in manila:
assignee: junboli (junboli) → Tom Barron (tpb)
Tom Barron (tpb)
Changed in manila:
assignee: Tom Barron (tpb) → junboli (junboli)
Changed in manila:
assignee: junboli (junboli) → Tom Barron (tpb)
Changed in manila:
assignee: Tom Barron (tpb) → junboli (junboli)
Changed in manila:
assignee: junboli (junboli) → Goutham Pacha Ravi (gouthamr)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/557206
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=cf677f2603a9943d99b6bcb9eb3b704a4f3afc52
Submitter: Zuul
Branch: master

commit cf677f2603a9943d99b6bcb9eb3b704a4f3afc52
Author: lijunbo <email address hidden>
Date: Tue Jul 24 12:00:58 2018 +0800

    Retrieve is_default value to fix empty display in CLI

    This bug is from path[1], when we use manila client to create
    a share type or share group type, the is_default value is always
    empty, so add the is_default value when we create each share type
    or share group type.

    Closes-bug: #1743941
    [1] Ib264d8422fe57701f990cbbf7ea5d1e90b8b0008

    Change-Id: Ia8bcb632591fc0b5438847b22ec59c2039ecf5f1

Changed in manila:
status: In Progress → Fix Released
Changed in python-manilaclient:
assignee: junboli (junboli) → Goutham Pacha Ravi (gouthamr)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/535178
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=ecbe1f961caae0283f3114c68271173804a785d6
Submitter: Zuul
Branch: master

commit ecbe1f961caae0283f3114c68271173804a785d6
Author: lijunbo <email address hidden>
Date: Tue Jul 24 22:54:06 2018 +0800

    Fix is_default value is empty issue when create

    When we use manila client to create a share type or share group
    type, the is_default value is always empty, this patch is to fix
    this issue.

    Depends-On: Ia8bcb632591fc0b5438847b22ec59c2039ecf5f1
    Change-Id: Ib264d8422fe57701f990cbbf7ea5d1e90b8b0008
    Closes-bug: #1743941

Changed in python-manilaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 1.24.0

This issue was fixed in the openstack/python-manilaclient 1.24.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 7.0.0.0b3

This issue was fixed in the openstack/manila 7.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila-tempest-plugin (master)

Reviewed: https://review.openstack.org/582819
Committed: https://git.openstack.org/cgit/openstack/manila-tempest-plugin/commit/?id=5dd4b582f4e26da69992d6507cea331b1afc1b17
Submitter: Zuul
Branch: master

commit 5dd4b582f4e26da69992d6507cea331b1afc1b17
Author: junboli <email address hidden>
Date: Tue Jul 24 12:25:22 2018 +0800

    Test is_default for share type and share group type

    The share type and share group type APIs in version 2.46
    returns is_default key, this patch is to test this featue.

    Depends-On: https://review.openstack.org/#/c/557206/
    Change-Id: I68f7bea991fb39c4667031b0125470936a28dc9f
    Partial-Bug: #1743941

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.