'cover' tox job fails not being able to find .testr.conf

Bug #1723655 reported by Valeriy Ponomaryov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Tom Barron

Bug Description

"cover" tox job does not work anymore after merge of [1] with following error:

$ tox -ecover
 cover create: /home/jenkins/workspace/manila-coverage-ubuntu-xenial-nv/.tox/cover
 cover installdeps: -r/home/jenkins/workspace/manila-coverage-ubuntu-xenial-nv/requirements.txt, -r/home/jenkins/workspace/manila-coverage-ubuntu-xenial-nv/test-requirements.txt
 cover develop-inst: /home/jenkins/workspace/manila-coverage-ubuntu-xenial-nv
 cover installed: alabaster==0.7.10,alembic==0.9.5,amqp==2.2.2,appdirs==1.4.3,asn1crypto==0.23.0,Babel==2.5.1,bashate==0.5.1,bcrypt==3.1.3,cachetools==2.0.1,certifi==2017.7.27.1,cffi==1.11.2,chardet==3.0.4,cliff==2.9.1,cmd2==0.7.7,contextlib2==0.5.5,coverage==4.4.1,cryptography==2.0.3,ddt==1.1.1,debtcollector==1.18.0,decorator==4.1.2,doc8==0.8.0,docutils==0.14,dulwich==0.18.4,enum-compat==0.0.2,enum34==1.1.6,eventlet==0.20.0,extras==1.0.0,fasteners==0.14.1,fixtures==3.0.0,flake8==2.5.5,funcsigs==1.0.2,future==0.16.0,futures==3.1.1,futurist==1.4.0,greenlet==0.4.12,hacking==0.12.0,idna==2.6,imagesize==0.7.1,ipaddress==1.0.18,iso8601==0.1.11,Jinja2==2.9.6,keystoneauth1==3.2.0,keystonemiddleware==4.17.0,kombu==4.1.0,linecache2==1.0.0,lxml==4.0.0,Mako==1.0.7,-e git+http://zm04.openstack.org/p/openstack/manila@7ba41320f3ee36116d114874cb01d589a92f3291#egg=manila,MarkupSafe==1.0,mccabe==0.2.1,mock==2.0.0,monotonic==1.3,mox3==0.23.0,msgpack-python==0.4.8,netaddr==0.7.19,netifaces==0.10.6,openstackdocstheme==1.17.0,os-api-ref==1.4.0,os-client-config==1.28.0,os-testr==1.0.0,osc-lib==1.7.0,oslo.concurrency==3.23.0,oslo.config==4.13.1,oslo.context==2.19.0,oslo.db==4.28.0,oslo.i18n==3.18.0,oslo.log==3.31.0,oslo.messaging==5.33.0,oslo.middleware==3.32.1,oslo.policy==1.28.1,oslo.reports==1.23.0,oslo.rootwrap==5.10.0,oslo.serialization==2.21.1,oslo.service==1.26.0,oslo.utils==3.30.0,oslotest==2.18.1,paramiko==2.3.1,Paste==2.0.3,PasteDeploy==1.5.2,pbr==3.1.1,pep8==1.5.7,pika==0.10.0,pika-pool==0.1.3,positional==1.2.1,prettytable==0.7.2,psutil==5.3.1,psycopg2==2.7.3.1,pyasn1==0.3.7,pycadf==2.6.0,pycparser==2.18,pyflakes==0.8.1,Pygments==2.2.0,pyinotify==0.9.6,PyMySQL==0.7.11,PyNaCl==1.1.2,pyparsing==2.2.0,pyperclip==1.5.27,python-cinderclient==3.2.0,python-dateutil==2.6.1,python-editor==1.0.3,python-keystoneclient==3.13.0,python-mimeparse==1.6.0,python-neutronclient==6.5.0,python-novaclient==9.1.1,python-subunit==1.2.0,pytz==2017.2,PyYAML==3.12,reno==2.5.1,repoze.lru==0.7,requests==2.18.4,requests-mock==1.3.0,requestsexceptions==1.3.0,restructuredtext-lint==1.1.1,retrying==1.3.3,rfc3986==1.1.0,Routes==2.4.1,simplejson==3.11.1,six==1.11.0,snowballstemmer==1.2.1,Sphinx==1.6.4,sphinxcontrib-websupport==1.0.1,SQLAlchemy==1.1.14,sqlalchemy-migrate==0.11.0,sqlparse==0.2.4,statsd==3.2.1,stestr==1.0.0,stevedore==1.27.1,Tempita==0.5.2,tenacity==4.4.0,testrepository==0.0.20,testresources==2.0.1,testscenarios==0.5.0,testtools==2.3.0,tooz==1.59.0,traceback2==1.4.0,typing==3.6.2,unicodecsv==0.14.1,unittest2==1.1.0,urllib3==1.22,vine==1.1.4,voluptuous==0.10.5,WebOb==1.7.3,wrapt==1.10.11
 cover runtests: PYTHONHASHSEED='2944280830'
 cover runtests: commands[0] | /home/jenkins/workspace/manila-coverage-ubuntu-xenial-nv/tools/cover.sh
 Warning: you are leaving 1 commit behind, not connected to
 any of your branches:

   7ba4132 Fix 'project_share_type_quotas' DB table unique constraint

 If you want to keep it by creating a new branch, this may be a good time
 to do so with:

  git branch <new-branch-name> 7ba4132

 HEAD is now at 647147b... Merge "Updated from global requirements"
 running testr
 No .testr.conf config file
 error: testr failed (3)
 Previous HEAD position was 647147b... Merge "Updated from global requirements"
 HEAD is now at 7ba4132... Fix 'project_share_type_quotas' DB table unique constraint
 running testr
 No .testr.conf config file
 error: testr failed (3)
 Allowed to introduce missing lines : 4
 Missing lines in master : to
 Missing lines in proposed change : to
 /home/jenkins/workspace/manila-coverage-ubuntu-xenial-nv/tools/cover.sh: line 53: [: to: integer expression expected
 Name Stmts Miss Cover
 Please write more unit tests, we should keep our test coverage :(
 ERROR: InvocationError: '/home/jenkins/workspace/manila-coverage-ubuntu-xenial-nv/tools/cover.sh'
 ___________________________________ summary ____________________________________
 ERROR: cover: commands failed

[1] https://github.com/openstack/manila/commit/ddccac8d

summary: - 'cover' tox job fails not being able to find .testr,.conf
+ 'cover' tox job fails not being able to find .testr.conf
Tom Barron (tpb)
Changed in manila:
assignee: nobody → Tom Barron (tpb)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/512065

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/512108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/512108
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=376e1836c66eaaaf0b7e4009689bf0b72eeb9e24
Submitter: Zuul
Branch: master

commit 376e1836c66eaaaf0b7e4009689bf0b72eeb9e24
Author: Tom Barron <email address hidden>
Date: Sun Oct 15 16:24:19 2017 -0400

    Restore .testr.conf

    .testr.conf was removed in favor of .stestr.conf in
    change [1] but the coverage job still uses it.

    Restore it alongside .stestr.conf until we convert
    the coverage job to use stestr.

    [1] I6bb369624c4a790242022e203e771a77ffe06cf5

    Closes-Bug: #1723655

    Change-Id: I451e383ed654d00a5a017cb28521c47566911f33

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.0.0.0b1

This issue was fixed in the openstack/manila 6.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.