use openflow to set security group, create port failed

[haobing1]

manila-share can not create when contral node use openflow to set security group.

Use "driver_handles_share_servers=True" backend driver.
When create service neutron port to connect with service instances,
we should set the port security group is disable, to prevent be added
the default security group in neutron. Because some cases the default
security group would lead to the port can not connect with the service
instances.

[Tom Barron (tpb)]

https://review.openstack.org/#/c/534631 has been proposed as a fix for this bug but I don't understand the failure cases mentioned in this bug and the fix seems perhaps overly broad.

[haobing1 (haobing1)]

@Tom,thanks for your review.
First,as you said in the https://review.openstack.org/#/c/534631, "this is a private port between manila-share and the share server so there's no need for a security group."
Second,in our testing environment,we use the SDN, we set the default security group to prohibit all traffic, in this case, will lead the port can not connect with the service instances.
Thank you !

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/534631
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3c3d899837e256d4692c4195f0e77ff600817e5c
Submitter: Zuul
Branch: master

commit 3c3d899837e256d4692c4195f0e77ff600817e5c
Author: haobing1 <email address hidden>
Date: Wed Jan 17 12:14:07 2018 +0800

    Disable security group rule when create port

    Use "driver_handles_share_servers=True" backend driver.
    When create service neutron port to connect with service instances,
    we should set the port security group is disable, to prevent be added
    the default security group in neutron. Because some cases the default
    security group would lead to the port can not connect with the service
    instances.

    Change-Id: Ib13e4f80c5a54b2b863b511ebb6e8f82700a3639
    Closes-Bug:#1720283

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/536004

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/536005

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/536004
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=7eb96210505a41a0261057e0469b4a050fe110f7
Submitter: Zuul
Branch: stable/pike

commit 7eb96210505a41a0261057e0469b4a050fe110f7
Author: haobing1 <email address hidden>
Date: Wed Jan 17 12:14:07 2018 +0800

    Disable security group rule when create port

    Use "driver_handles_share_servers=True" backend driver.
    When create service neutron port to connect with service instances,
    we should set the port security group is disable, to prevent be added
    the default security group in neutron. Because some cases the default
    security group would lead to the port can not connect with the service
    instances.

    Change-Id: Ib13e4f80c5a54b2b863b511ebb6e8f82700a3639
    Closes-Bug:#1720283
    (cherry picked from commit 3c3d899837e256d4692c4195f0e77ff600817e5c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 6.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/536005
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=7609c2eca96f80c04734bdb5347a2db1c2991f46
Submitter: Zuul
Branch: stable/ocata

commit 7609c2eca96f80c04734bdb5347a2db1c2991f46
Author: haobing1 <email address hidden>
Date: Wed Jan 17 12:14:07 2018 +0800

    Disable security group rule when create port

    Use "driver_handles_share_servers=True" backend driver.
    When create service neutron port to connect with service instances,
    we should set the port security group is disable, to prevent be added
    the default security group in neutron. Because some cases the default
    security group would lead to the port can not connect with the service
    instances.

    Change-Id: Ib13e4f80c5a54b2b863b511ebb6e8f82700a3639
    Closes-Bug:#1720283
    (cherry picked from commit 3c3d899837e256d4692c4195f0e77ff600817e5c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 5.0.2 release.