tempest: scenario.test_share_basic_ops.TestShareBasicOps fails

[Tom Barron]

Failures with dummy patch set (no substantive changes) have appeared: "RuntimeError: set_network_resources invoked after setup_credentials on the super class has been already invoked. For set_network_resources to have effect please invoke it before the call to super().setup_credentials"

Actual log: http://logs.openstack.org/22/479022/5/check/gate-manila-tempest-minimal-dsvm-lvm-ubuntu-xenial/0f9c67a/console.html#_2017-09-15_15_46_24_155756

The issue appears to be exposed by this tempest commit:

commit 2c8db1a8053b694756034fd250d8cf1611937232
Merge: 7dcb98f bcbf1af1
Author: Jenkins <email address hidden>
Date: Thu Sep 14 19:07:16 2017 +0000

    Merge "Prepare network_resources as a stable interface"

commit bcbf1af1e3ac5f6eaddbfd7171e3c21bc2ee2bd2
Author: Andrea Frittoli <email address hidden>
Date: Mon Aug 14 11:53:35 2017 +0100

    Prepare network_resources as a stable interface

    The network_resources attribute should not be a public interface,
    so renaming it to _network_resources. Document set_network_resources
    better; ensure it's only invoked before super's setup_credentials is
    invoked to avoid the call being ignored and generate errors that
    may be difficult to debug.

    Change-Id: I4eab8f2a722b47edc20e4aab0ef453bec16842f3

The tempest change looks reasonable so we should figure how to set_network_resources earlier, before the super's setup_credentials has been invoked.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/504471

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/504504

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tom Barron (<email address hidden>) on branch: master
Review: https://review.openstack.org/504471
Reason: in favor of https://review.openstack.org/#/c/504504

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/504504
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c26bd6b10c608029a505d3473b0bf61e178deee7
Submitter: Jenkins
Branch: master

commit c26bd6b10c608029a505d3473b0bf61e178deee7
Author: Dustin Schoenbrun <email address hidden>
Date: Fri Sep 15 15:55:53 2017 -0400

    tempest: remove call to set_network_resources()

    Since the merge of the stable interface for Tempest network_resources
    [0], a call within the Manila scenario tests was causing failures
    around the ordering of method calls in the set up of the test class.
    This patch removes the call as currently it doesn't do anything and
    will fix our scenario tests.

    [0] - I4eab8f2a722b47edc20e4aab0ef453bec16842f3

    Change-Id: Ia9226329035508c37ca499e6efbd2382502eb141
    Closes-Bug: #1717562

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/517932

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517932
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=699f0a7d2699d93b2177b163d2d614115b055407
Submitter: Zuul
Branch: stable/pike

commit 699f0a7d2699d93b2177b163d2d614115b055407
Author: Dustin Schoenbrun <email address hidden>
Date: Fri Sep 15 15:55:53 2017 -0400

    tempest: remove call to set_network_resources()

    Since the merge of the stable interface for Tempest network_resources
    [0], a call within the Manila scenario tests was causing failures
    around the ordering of method calls in the set up of the test class.
    This patch removes the call as currently it doesn't do anything and
    will fix our scenario tests.

    [0] - I4eab8f2a722b47edc20e4aab0ef453bec16842f3

    Change-Id: Ia9226329035508c37ca499e6efbd2382502eb141
    Closes-Bug: #1717562
    (cherry picked from commit c26bd6b10c608029a505d3473b0bf61e178deee7)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/518026

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 6.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/518026
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f3820a7b2f87b09f032c419ab538a14ef219b40a
Submitter: Zuul
Branch: stable/ocata

commit f3820a7b2f87b09f032c419ab538a14ef219b40a
Author: Dustin Schoenbrun <email address hidden>
Date: Fri Sep 15 15:55:53 2017 -0400

    tempest: remove call to set_network_resources()

    Since the merge of the stable interface for Tempest network_resources
    [0], a call within the Manila scenario tests was causing failures
    around the ordering of method calls in the set up of the test class.
    This patch removes the call as currently it doesn't do anything and
    will fix our scenario tests.

    [0] - I4eab8f2a722b47edc20e4aab0ef453bec16842f3

    Change-Id: Ia9226329035508c37ca499e6efbd2382502eb141
    Closes-Bug: #1717562
    (cherry picked from commit c26bd6b10c608029a505d3473b0bf61e178deee7)
    (cherry picked from commit 699f0a7d2699d93b2177b163d2d614115b055407)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 5.0.2 release.