exception when downgrading db from '579c267fbb4d' to '5077ffcc5f1c'

Bug #1717392 reported by zhiguo.li on 2017-09-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Manila
Medium
Goutham Pacha Ravi

Bug Description

When running method downgrade() in 579c267fbb4d_add_share_instances_access_map.py, an exception may occur if the 'access_mapping' is None type.
The exception is like this: TypeError: 'NoneType' object has no attribute '__getitem__'.

Fix proposed to branch: master
Review: https://review.openstack.org/504296

Changed in manila:
assignee: nobody → zhiguo.li (zhiguo)
status: New → In Progress
Changed in manila:
importance: Undecided → Medium
milestone: none → queens-1

I uploaded the data exported from table 'share_instance_access_map' and 'share_access_map' for explaing this bug.

Changed in manila:
assignee: zhiguo.li (zhiguo) → Tom Barron (tpb)
Tom Barron (tpb) on 2018-06-19
summary: - Exsist exception when downgrading db from '579c267fbb4d' to
- '5077ffcc5f1c'
+ exception when downgrading db from '579c267fbb4d' to '5077ffcc5f1c'
Changed in manila:
assignee: Tom Barron (tpb) → nobody
assignee: nobody → zhiguo.li (zhiguo)
tags: added: db-migration
Changed in manila:
milestone: queens-1 → rocky-3
Changed in manila:
assignee: zhiguo.li (zhiguo) → Goutham Pacha Ravi (gouthamr)

Reviewed: https://review.openstack.org/504296
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=12841fe01656d2cd4ae1e8b69d02dd7ff9e1a3a4
Submitter: Zuul
Branch: master

commit 12841fe01656d2cd4ae1e8b69d02dd7ff9e1a3a4
Author: zhiguo.li <email address hidden>
Date: Fri Sep 15 09:32:52 2017 +0800

    DB Migration: fix downgrade in 579c267fbb4d

    The downgrade incorrectly modifies deleted
    share access rules.

    Also add a missing unit test for this migration.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>
    Change-Id: If3700e7a18cbd8ae496b8c503c95cf6723485679
    Closes-Bug: #1717392

Changed in manila:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/579236
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=846a1597d342feaa58d4c773eae22c880f031508
Submitter: Zuul
Branch: stable/queens

commit 846a1597d342feaa58d4c773eae22c880f031508
Author: zhiguo.li <email address hidden>
Date: Fri Sep 15 09:32:52 2017 +0800

    DB Migration: fix downgrade in 579c267fbb4d

    The downgrade incorrectly modifies deleted
    share access rules.

    Also add a missing unit test for this migration.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>
    Change-Id: If3700e7a18cbd8ae496b8c503c95cf6723485679
    Closes-Bug: #1717392
    (cherry picked from commit 12841fe01656d2cd4ae1e8b69d02dd7ff9e1a3a4)

tags: added: in-stable-queens

This issue was fixed in the openstack/manila 6.0.2 release.

This issue was fixed in the openstack/manila 7.0.0.0b3 development milestone.

Reviewed: https://review.openstack.org/585905
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0028c6b96436bd0b987ca3abae4aa673b6f3024b
Submitter: Zuul
Branch: stable/pike

commit 0028c6b96436bd0b987ca3abae4aa673b6f3024b
Author: zhiguo.li <email address hidden>
Date: Fri Sep 15 09:32:52 2017 +0800

    DB Migration: fix downgrade in 579c267fbb4d

    The downgrade incorrectly modifies deleted
    share access rules.

    Also add a missing unit test for this migration.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>
    Change-Id: If3700e7a18cbd8ae496b8c503c95cf6723485679
    Closes-Bug: #1717392
    (cherry picked from commit 12841fe01656d2cd4ae1e8b69d02dd7ff9e1a3a4)
    (cherry picked from commit 846a1597d342feaa58d4c773eae22c880f031508)

tags: added: in-stable-pike

This issue was fixed in the openstack/manila 5.0.2 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers