I'm using ganesha driver with manila. In my test environment, it generated many invalid configuration files like::
1.conf.djkfjkd
2.conf.djfkdjl
3.conf.kllsjdk
.....
These files are the temp file which were generated in creating ganesha export configuration files.
def _write_file(self, path, data):
"""Write data to path atomically."""
dirpath, fname = (getattr(os.path, q + "name")(path) for q in
("dir", "base"))
tmpf = self.execute('mktemp', '-p', dirpath, "-t",
fname + ".XXXXXX")[0][:-1]
self.execute(
'sh', '-c',
'echo %s > %s' % (pipes.quote(data), pipes.quote(tmpf)),
message='writing ' + tmpf)
self.execute('mv', tmpf, path)
In ganesha driver, we use two 'ssh' operations to generate a valid export configuration file. But some times the second 'ssh' operation may execute failed. In this case, ganesha driver will generate invalid files (the tmpf file). IMO, we should add try catch block on second ssh operation to avoid it happen.
Fix proposed to branch: master
Review: https:/