OpenStack Shared File Systems Service (Manila)

Security group creation failed

Bug #1716922 reported by Jan Vondra
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Jan Vondra

Bug Description

Steps to reproduce:
1. Create fresh devstack installation
2. Delete manila-service security group
3. Attempt to recreate the security group fails with following traceback:
2017-09-13 13:19:56.795 ERROR oslo_messaging.rpc.server [req-66f42c3e-b27b-4615-8c4c-99a6fba26832 199cb16eb50647ed9064d789ecfd0f38 a086299e011c42fbb16dd998d08c180b] Exception during message handling: NetworkException: Unable to find 'security_group' in request body
Neutron server returns request_ids: ['req-8c1889ee-118b-42f3-b8d3-b3f8474c0b48']
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server Traceback (most recent call last):
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 213, in dispatch
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 183, in _do_dispatch
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server result = func(ctxt, **new_args)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 186, in wrapped
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server return f(self, *args, **kwargs)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/utils.py", line 560, in wrapper
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server return func(self, *args, **kwargs)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 1635, in create_share_instance
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server detail=message_field.Detail.NO_SHARE_SERVER)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server self.force_reraise()
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 1617, in create_share_instance
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server share_group=share_group_ref,
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 537, in _provide_share_server_for_share
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server return _wrapped_provide_share_server_for_share()
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py", line 271, in inner
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server return f(*args, **kwargs)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 533, in _wrapped_provide_share_server_for_share
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server metadata=metadata))
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 549, in _create_share_server_in_backend
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server metadata=metadata)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 3427, in _setup_server
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server self.driver.deallocate_network(context, share_server['id'])
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server self.force_reraise()
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/manager.py", line 3378, in _setup_server
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server network_info, metadata=metadata)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/driver.py", line 893, in setup_server
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server return self._setup_server(*args, **kwargs)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/generic.py", line 878, in _setup_server
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server self.admin_context, network_info)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/service_instance.py", line 407, in set_up_service_instance
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server context, instance_name, network_info)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/service_instance.py", line 545, in _create_service_instance
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server security_group = self._get_or_create_security_group(context)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py", line 271, in inner
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server return f(*args, **kwargs)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/share/drivers/service_instance.py", line 336, in _get_or_create_security_group
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server name, description)['security_group']
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server File "/opt/stack/manila/manila/network/neutron/api.py", line 388, in security_group_create
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server code=e.status_code, message=e.message)
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server NetworkException: Unable to find 'security_group' in request body
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server Neutron server returns request_ids: ['req-8c1889ee-118b-42f3-b8d3-b3f8474c0b48']
2017-09-13 13:19:56.795 TRACE oslo_messaging.rpc.server

The most probable cause is some change in neutronclient.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/503724

Changed in manila:
assignee: nobody → Jan Vondra (janvondra)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/503724
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c93f5833e4100d2325994b1bdf8f0d12b70d00c7
Submitter: Jenkins
Branch: master

commit c93f5833e4100d2325994b1bdf8f0d12b70d00c7
Author: Jan Vondra <email address hidden>
Date: Wed Sep 13 17:58:37 2017 +0200

    Fixed creation neutron api mapping for security groups

    Fixed creation of security group and security group rule via
    neutronclient api mapping.
    There was a switch from novaclient to neutronclient
    for creating a security groups and rules in change
    5d5666b10e57a94bcde06c8a296002175d935c7b but
    the argument mapping for this function has not been changed.

    Change-Id: I1774b73c61adb3b44a61f3f56f99e85f278deb83
    Closes-Bug: 1716922

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/508417

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.0.0.0b1

This issue was fixed in the openstack/manila 6.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/pike)

Reviewed: https://review.openstack.org/508417
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=7d7022f74301db90b8a0ccd634a592991598156e
Submitter: Zuul
Branch: stable/pike

commit 7d7022f74301db90b8a0ccd634a592991598156e
Author: Jan Vondra <email address hidden>
Date: Wed Sep 13 17:58:37 2017 +0200

    Fixed creation neutron api mapping for security groups

    Fixed creation of security group and security group rule via
    neutronclient api mapping.
    There was a switch from novaclient to neutronclient
    for creating a security groups and rules in change
    5d5666b10e57a94bcde06c8a296002175d935c7b but
    the argument mapping for this function has not been changed.

    Change-Id: I1774b73c61adb3b44a61f3f56f99e85f278deb83
    Closes-Bug: 1716922
    (cherry picked from commit c93f5833e4100d2325994b1bdf8f0d12b70d00c7)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/518601

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/ocata)

Reviewed: https://review.openstack.org/518601
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=21d6184097582deb3236854c5c1e10ad40582dcc
Submitter: Zuul
Branch: stable/ocata

commit 21d6184097582deb3236854c5c1e10ad40582dcc
Author: Jan Vondra <email address hidden>
Date: Wed Sep 13 17:58:37 2017 +0200

    Fixed creation neutron api mapping for security groups

    Fixed creation of security group and security group rule via
    neutronclient api mapping.
    There was a switch from novaclient to neutronclient
    for creating a security groups and rules in change
    5d5666b10e57a94bcde06c8a296002175d935c7b but
    the argument mapping for this function has not been changed.

    Change-Id: I1774b73c61adb3b44a61f3f56f99e85f278deb83
    Closes-Bug: 1716922
    (cherry picked from commit c93f5833e4100d2325994b1bdf8f0d12b70d00c7)
    (cherry picked from commit 7d7022f74301db90b8a0ccd634a592991598156e)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 4.0.2

This issue was fixed in the openstack/manila 4.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 5.0.2

This issue was fixed in the openstack/manila 5.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.