Duplicate hacking check for M312

Bug #1710426 reported by junboli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Undecided
junboli

Bug Description

[H203] Use assertIs(Not)None to check for None. is already enabled in tox, So the duplicated hacking check for M312 is unnecessary.

junboli (junboli)
Changed in manila:
assignee: nobody → junboli (junboli)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/493340

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/493340
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ca712cb0bd2e271bd05265622a9b70a4ccdaff45
Submitter: Jenkins
Branch: master

commit ca712cb0bd2e271bd05265622a9b70a4ccdaff45
Author: junboli <email address hidden>
Date: Sun Aug 13 08:01:42 2017 +0800

    Fix the duplicate hacking check M312 and H203

    The hacking "[H203] Use assertIs(Not)None to check for None" is already enabled
    in tox. But the local hacking M312 is also avaliable, there is no need to check
    twice here for the same check.

    Change-Id: I56e19c6dd8905e439247c3b142e74913b5d0d7a6
    Closes-Bug: #1710426

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.0.0.0b1

This issue was fixed in the openstack/manila 6.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers