Quota usage value error

[zhongjun]

Steps to reproduce:

We have 4 share-api service in each 4 vm

# manila create NFS 1 #create a new share
# manila quota-show --detail #The number of shares is equal to 4, the gigabytes is equal to 4
+-----------------------+----------------------------------+
| Property | Value |
+-----------------------+----------------------------------+
| share_groups | in_use = 0 |
| | limit = 50 |
| | reserved = 0 |
| gigabytes | in_use = 4 |
| | limit = 1000 |
| | reserved = 0 |
| snapshot_gigabytes | in_use = 0 |
| | limit = 1000 |
| | reserved = 0 |
| shares | in_use = 4 |
| | limit = 50 |
| | reserved = 0 |

#manila delete share_id # Delete the same share at the same time in each 4 vm
# manila quota-show --detail # The number of shares is equal to 0, the gigabytes is equal to 0
+-----------------------+----------------------------------+
| Property | Value |
+-----------------------+----------------------------------+
| share_groups | in_use = 0 |
| | limit = 50 |
| | reserved = 0 |
| gigabytes | in_use = 0 |
| | limit = 1000 |
| | reserved = 0 |
| snapshot_gigabytes | in_use = 0 |
| | limit = 1000 |
| | reserved = 0 |
| shares | in_use = 0 |
| | limit = 50 |
| | reserved = 0 |

We only delete one share, but the number of shares changed from 4 to 0, the gigabytes also changed from 4 to 0.

[Ben Swartzlander (bswartz)]

This bug to be fixed as part of the quota system rewrite planned for Rocky.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/493071
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=3c596304991927f62290fd940a7f518ec1cae4a2
Submitter: Zuul
Branch: master

commit 3c596304991927f62290fd940a7f518ec1cae4a2
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Aug 11 19:16:16 2017 +0300

    Fix quota usages update deleting same share from several API endpoints

    It is possible to update quota usages multiple times sending share
    deletion request to several API endpoints concurrently.
    So, move quota usages update logic that is triggered by share deletion,
    to DB functions level, which will be able to be executed only when
    share deletion succeded. So, all concurrent requests, that failed to
    delete DB record, won't commit quota usages updates.

    Change-Id: If7d52e08d00d435f2e26c30654f0d2180b17b81a
    Closes-Bug: #1707379
    Closes-bug: #1707377

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 6.0.0.0b3 development milestone.