NetApp manila driver keep QoS policy on backend during migration

[Yogesh]

NetApp Manila driver, leaves the policy untouched during migration of share, even if user is retyping the share to not have QoS on migrated share.

Steps to reproduce:
1. Create share type with QoS=True
2. Create share with above share policy.
3. Create new share type with QoS extra-specs.
4. Migrate the above share with newly created non-qos share type.
5. Verify that migrated share do not have QoS policy attached to it on backend.

Actual Result - QoS policy still remains with the migrated share.

[Ben Swartzlander (bswartz)]

Missed pike, untargetting

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/713073

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/713073
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=14b75b1fdd753c6d90c301cd4576706024a9356f
Submitter: Zuul
Branch: master

commit 14b75b1fdd753c6d90c301cd4576706024a9356f
Author: Naresh Kumar Gunjalli <email address hidden>
Date: Mon Jun 17 07:15:21 2019 -0400

    [NetApp] cDOT to set valid QoS during migration

    NetApp cDOT driver is now fixed to remove the QoS Policy on the
    backend volume when a share is migrated from an extra-spec which had
    QoS defined to another extra-spec which has no QoS defined in it.

    Change-Id: I57c2e15fc22eb2bf69ebee25a92ba10746505e73
    Closes-Bug: #1706137

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/716044

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/719132

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/716044
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=1fddc0794f89dc9fb8381e622855d76839136c5d
Submitter: Zuul
Branch: stable/train

commit 1fddc0794f89dc9fb8381e622855d76839136c5d
Author: Naresh Kumar Gunjalli <email address hidden>
Date: Mon Jun 17 07:15:21 2019 -0400

    [NetApp] cDOT to set valid QoS during migration

    NetApp cDOT driver is now fixed to remove the QoS Policy on the
    backend volume when a share is migrated from an extra-spec which had
    QoS defined to another extra-spec which has no QoS defined in it.

    Change-Id: I57c2e15fc22eb2bf69ebee25a92ba10746505e73
    Closes-Bug: #1706137
    (cherry picked from commit 14b75b1fdd753c6d90c301cd4576706024a9356f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/719132
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=15dc973b17cb0557f192a97d1efcb8ce235c54e1
Submitter: Zuul
Branch: stable/stein

commit 15dc973b17cb0557f192a97d1efcb8ce235c54e1
Author: Naresh Kumar Gunjalli <email address hidden>
Date: Mon Jun 17 07:15:21 2019 -0400

    [NetApp] cDOT to set valid QoS during migration

    NetApp cDOT driver is now fixed to remove the QoS Policy on the
    backend volume when a share is migrated from an extra-spec which had
    QoS defined to another extra-spec which has no QoS defined in it.

    Change-Id: I57c2e15fc22eb2bf69ebee25a92ba10746505e73
    Closes-Bug: #1706137
    (cherry picked from commit 14b75b1fdd753c6d90c301cd4576706024a9356f)
    (cherry picked from commit 1fddc0794f89dc9fb8381e622855d76839136c5d)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/723621

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/723621
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6e52af90f828c6fc34cad4bd788e9264c321bac0
Submitter: Zuul
Branch: stable/rocky

commit 6e52af90f828c6fc34cad4bd788e9264c321bac0
Author: Naresh Kumar Gunjalli <email address hidden>
Date: Mon Jun 17 07:15:21 2019 -0400

    [NetApp] cDOT to set valid QoS during migration

    NetApp cDOT driver is now fixed to remove the QoS Policy on the
    backend volume when a share is migrated from an extra-spec which had
    QoS defined to another extra-spec which has no QoS defined in it.

    Change-Id: I57c2e15fc22eb2bf69ebee25a92ba10746505e73
    Closes-Bug: #1706137
    (cherry picked from commit 14b75b1fdd753c6d90c301cd4576706024a9356f)
    (cherry picked from commit 1fddc0794f89dc9fb8381e622855d76839136c5d)
    (cherry picked from commit 15dc973b17cb0557f192a97d1efcb8ce235c54e1)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/725109

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/725109
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=66117610f92fe3e7632980ccef007ced7f952385
Submitter: Zuul
Branch: stable/queens

commit 66117610f92fe3e7632980ccef007ced7f952385
Author: Naresh Kumar Gunjalli <email address hidden>
Date: Mon Jun 17 07:15:21 2019 -0400

    [NetApp] cDOT to set valid QoS during migration

    NetApp cDOT driver is now fixed to remove the QoS Policy on the
    backend volume when a share is migrated from an extra-spec which had
    QoS defined to another extra-spec which has no QoS defined in it.

    Change-Id: I57c2e15fc22eb2bf69ebee25a92ba10746505e73
    Closes-Bug: #1706137
    (cherry picked from commit 14b75b1fdd753c6d90c301cd4576706024a9356f)
    (cherry picked from commit 1fddc0794f89dc9fb8381e622855d76839136c5d)
    (cherry picked from commit 15dc973b17cb0557f192a97d1efcb8ce235c54e1)
    (cherry picked from commit 6e52af90f828c6fc34cad4bd788e9264c321bac0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila rocky-eol release.