metadata update fails if preferered is null as the database schema doesn't allows null value

[David Hill]

metadata update fails if preferered is null as the database schema doesn't allows null value and here is a patch to fix in in sqlalchemy.

[root@lab-openstack01 sqlalchemy(keystone_admin)]# diff -u api.py.orig api.py
--- api.py.orig 2017-07-11 13:47:55.591859922 -0400
+++ api.py 2017-07-11 14:15:32.904711884 -0400
@@ -2546,6 +2546,8 @@
         # that will not take effect using one session and we will rewrite,
         # in that case, single record - first one added with this call.
         session = get_session()
+ if not meta_value:
+ meta_value = 'none'
         item = {"value": meta_value, "updated_at": timeutils.utcnow()}

         meta_ref = _export_location_metadata_get_query(

[David Hill (david-hill-ubisoft)]

Also, this is reproducable if we're not using clustering admin credentials to interface with the netapp appliance.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/482672

[Goutham Pacha Ravi (gouthamr)]

It seems like the driver should always set "preferred" metadata value to True or False, and not None.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/482672
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4573826d361b44c367ca54c5d0f7943346666ade
Submitter: Jenkins
Branch: master

commit 4573826d361b44c367ca54c5d0f7943346666ade
Author: Dave Hill <email address hidden>
Date: Tue Jul 11 15:02:13 2017 -0400

    NetApp: Define 'preferred' to False instead of none

    Define preferred to false instead of none in the NetApp driver
    as setting it to none will trigger a traceback later on because
    the database doesn't allow null values to be inserted.
    "preferred" export location metadata must be set to true or
    false. warning logging is also added to the SQLAlchemy API
    if a none value is used to update the export location metadata.

    Change-Id: Ie7420c9286cc42eaa1361eeffe607b9b5b6b3fbd
    Closes-Bug: 1703660

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/485781

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/485781
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=0a5d760ed5e49b0aef34ce909d4570585e1b4681
Submitter: Jenkins
Branch: stable/ocata

commit 0a5d760ed5e49b0aef34ce909d4570585e1b4681
Author: Dave Hill <email address hidden>
Date: Tue Jul 11 15:02:13 2017 -0400

    NetApp: Define 'preferred' to False instead of none

    Define preferred to false instead of none in the NetApp driver
    as setting it to none will trigger a traceback later on because
    the database doesn't allow null values to be inserted.
    "preferred" export location metadata must be set to true or
    false. warning logging is also added to the SQLAlchemy API
    if a none value is used to update the export location metadata.

    Change-Id: Ie7420c9286cc42eaa1361eeffe607b9b5b6b3fbd
    Closes-Bug: 1703660
    (cherry picked from commit 4573826d361b44c367ca54c5d0f7943346666ade)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: driverfixes/newton
Review: https://review.openstack.org/486666

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 5.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.1 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/486666
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6dd4039a304061df122153c6f6f3a00a5e33db64
Submitter: Zuul
Branch: driverfixes/newton

commit 6dd4039a304061df122153c6f6f3a00a5e33db64
Author: Dave Hill <email address hidden>
Date: Tue Jul 11 15:02:13 2017 -0400

    NetApp: Define 'preferred' to False instead of none

    Define preferred to false instead of none in the NetApp driver
    as setting it to none will trigger a traceback later on because
    the database doesn't allow null values to be inserted.
    "preferred" export location metadata must be set to true or
    false. warning logging is also added to the SQLAlchemy API
    if a none value is used to update the export location metadata.

    Change-Id: Ie7420c9286cc42eaa1361eeffe607b9b5b6b3fbd
    Closes-Bug: 1703660
    (cherry picked from commit 4573826d361b44c367ca54c5d0f7943346666ade)
    (cherry picked from commit 0a5d760ed5e49b0aef34ce909d4570585e1b4681)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: driverfixes/mitaka
Review: https://review.openstack.org/514804

[OpenStack Infra (hudson-openstack)]

Change abandoned by Goutham Pacha Ravi (<email address hidden>) on branch: driverfixes/mitaka
Review: https://review.openstack.org/514804
Reason: This patch suffers from the constraints issue; however, I don't see any value of back porting this fix to driverfixes/mitaka, since we are not cutting any releases from this branch. Rodrigo, Tiago: If you feel this needs to be revived, please feel free to restore. Thanks!