Manila Tempest Tests - CIFS multi-tenancy tests fail with pre-existing network

[Yogesh]

For CIFS - DHSS = True, Manila Tempest Tests need share_network already configured with Security Service before running the tempest tests.
We then specify this share-network in tempest.conf.

However, tempest tests are cleaning up this share network, causing the rest of the tests to fail due to unavailability of CIFS-configured Share Network.

Steps to reproduce -
1. Create a Share Network.
2. Create a Security Service with right configuration of CIFS server.
3. Add Security Service to Share Network that was created in step 1.
4. Add this Share Network Id to tempest.conf under [share] section as a config option - "share_network_id".
5. Also, set "create_networks_when_multitenancy_enabled" = False.
6. Run test_share_networks.py
7. At the end of this script, check "manila share-network-list".

Expected Result - Share Network created earlier should still be available.
Actual Result - The share network is deleted as part of resource clean up.

Now, any tests that require share_network is going to fail.

Workaround -
Comment below 3 lines in base.py -

elif res["type"] is "share_network":
    client.delete_share_network(res_id)
    client.wait_for_resource_deletion(sn_id=res_id)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/491841

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/491841
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=29a52269aa0d70006e2f0537780e68369da619d0
Submitter: Jenkins
Branch: master

commit 29a52269aa0d70006e2f0537780e68369da619d0
Author: yogesh <email address hidden>
Date: Mon Jun 26 13:16:12 2017 -0400

    [Tempest] Fix tests for pre-existing share network

    Currently tempest tests do not support creating and
    adding Security Service to newly created share networks.
    This causes CIFS multitenancy tests to fail on some
    of the backends.
    Therefore, having pre-existing share network helps
    testing such scenarios.

    When using a pre-existing share network,
    we can still test the share network API and
    create share networks, however, we shouldn't
    create shares on such networks.
    So, any tests that create new share networks
    and use them to create shares need to be skipped.

    - This patch makes sure that the pre-existing
    share_network is not cleaned up.
    - One share_server related test is skipped
    to avoid deleting share network as part of test.
    - One share network negative test is skipped
    to avoid creating a share with new share network.

    Change-Id: I272806b05c8b4d30451d0cf4b9dd3f366b8bf728
    Closes-Bug: #1698429

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 5.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/493962

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/493962
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=ed62a751c56b273362aa11696a3e72ae05f714f2
Submitter: Zuul
Branch: stable/ocata

commit ed62a751c56b273362aa11696a3e72ae05f714f2
Author: yogesh <email address hidden>
Date: Mon Jun 26 13:16:12 2017 -0400

    [Tempest] Fix tests for pre-existing share network

    Currently tempest tests do not support creating and
    adding Security Service to newly created share networks.
    This causes CIFS multitenancy tests to fail on some
    of the backends.
    Therefore, having pre-existing share network helps
    testing such scenarios.

    When using a pre-existing share network,
    we can still test the share network API and
    create share networks, however, we shouldn't
    create shares on such networks.
    So, any tests that create new share networks
    and use them to create shares need to be skipped.

    - This patch makes sure that the pre-existing
    share_network is not cleaned up.
    - One share_server related test is skipped
    to avoid deleting share network as part of test.
    - One share network negative test is skipped
    to avoid creating a share with new share network.

    Change-Id: I272806b05c8b4d30451d0cf4b9dd3f366b8bf728
    Closes-Bug: #1698429
    (cherry picked from commit 29a52269aa0d70006e2f0537780e68369da619d0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.2 release.