NetApp cDOT driver fails to revert to failed-over replicated snapshot or migrated snapshot

[Clinton Knight]

The NetApp cDOT driver supports snapshot revert as well as DR-style replication. Reverting a replicated share to a snapshot works fine if the active replica is the original one, but it fails if the share has been failed over to one of the replicas. The simple fix is to use the provider_location field on the snapshot to correctly identify it regardless of which replica is active.

[Goutham Pacha Ravi (gouthamr)]

Looks like the behavior affects migration as well. Renaming this bug since the fix is similar in both scenarios.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/497236

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/497236
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=bd47f93007227719e8b9eebbef9767d27025a236
Submitter: Jenkins
Branch: master

commit bd47f93007227719e8b9eebbef9767d27025a236
Author: Clinton Knight <email address hidden>
Date: Wed May 31 13:52:02 2017 -0400

    NetApp ONTAP: Fix revert-to-snapshot

    In course of normal operation, the backend snapshot
    name is associated with the the ID of the snapshot instance
    in manila.

    However, when a share is replicated or is being migrated,
    the backend snapshot is not renamed. Instead, we simply
    store the original name in the "provider_location" field of
    the snapshot model.

    Fix revert-to-snapshot methods to identify snapshots by
    "provider_location"s rather than the instance IDs.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>

    Change-Id: I4900c7aecc3da6640ea9c0d4d08012ff5b68cc58
    Closes-Bug: #1694768

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/498080

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/499416

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/498080
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=038eb7be4fa75fd7b8c2ad2a69f831e7186dbb9f
Submitter: Jenkins
Branch: stable/pike

commit 038eb7be4fa75fd7b8c2ad2a69f831e7186dbb9f
Author: Clinton Knight <email address hidden>
Date: Wed May 31 13:52:02 2017 -0400

    NetApp ONTAP: Fix revert-to-snapshot

    In course of normal operation, the backend snapshot
    name is associated with the the ID of the snapshot instance
    in manila.

    However, when a share is replicated or is being migrated,
    the backend snapshot is not renamed. Instead, we simply
    store the original name in the "provider_location" field of
    the snapshot model.

    Fix revert-to-snapshot methods to identify snapshots by
    "provider_location"s rather than the instance IDs.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>

    Change-Id: I4900c7aecc3da6640ea9c0d4d08012ff5b68cc58
    Closes-Bug: #1694768
    (cherry picked from commit bd47f93007227719e8b9eebbef9767d27025a236)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 5.0.1 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: driverfixes/ocata
Review: https://review.openstack.org/508966

[OpenStack Infra (hudson-openstack)]

Change abandoned by Goutham Pacha Ravi (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/499416
Reason: cherry-pick is appropriate within driverfixes/ocata instead: https://review.openstack.org/#/c/508966/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/508966
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c789d64a8aa36b796b3ad62f7755726082be2906
Submitter: Zuul
Branch: driverfixes/ocata

commit c789d64a8aa36b796b3ad62f7755726082be2906
Author: Clinton Knight <email address hidden>
Date: Wed May 31 13:52:02 2017 -0400

    NetApp ONTAP: Fix revert-to-snapshot

    In course of normal operation, the backend snapshot
    name is associated with the the ID of the snapshot instance
    in manila.

    However, when a share is replicated or is being migrated,
    the backend snapshot is not renamed. Instead, we simply
    store the original name in the "provider_location" field of
    the snapshot model.

    Fix revert-to-snapshot methods to identify snapshots by
    "provider_location"s rather than the instance IDs.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>

    Change-Id: I4900c7aecc3da6640ea9c0d4d08012ff5b68cc58
    Closes-Bug: #1694768
    (cherry picked from commit bd47f93007227719e8b9eebbef9767d27025a236)
    (cherry picked from commit 038eb7be4fa75fd7b8c2ad2a69f831e7186dbb9f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 6.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499416
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=b1d73fdb8682db16029f0e28620c0590f04bc6f5
Submitter: Zuul
Branch: stable/ocata

commit b1d73fdb8682db16029f0e28620c0590f04bc6f5
Author: Clinton Knight <email address hidden>
Date: Wed May 31 13:52:02 2017 -0400

    NetApp ONTAP: Fix revert-to-snapshot

    In course of normal operation, the backend snapshot
    name is associated with the the ID of the snapshot instance
    in manila.

    However, when a share is replicated or is being migrated,
    the backend snapshot is not renamed. Instead, we simply
    store the original name in the "provider_location" field of
    the snapshot model.

    Fix revert-to-snapshot methods to identify snapshots by
    "provider_location"s rather than the instance IDs.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>

    Change-Id: I4900c7aecc3da6640ea9c0d4d08012ff5b68cc58
    Closes-Bug: #1694768
    (cherry picked from commit bd47f93007227719e8b9eebbef9767d27025a236)
    (cherry picked from commit 038eb7be4fa75fd7b8c2ad2a69f831e7186dbb9f)
    (cherry picked from commit c789d64a8aa36b796b3ad62f7755726082be2906)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.2 release.