generic driver fails to get service image

[Valeriy Ponomaryov]

Generic driver uses Nova VMs and depends on service image. Till now it has been using novaclient for getting it. But, image API support has been removed from novaclient and now we get following errors running latest novaclient:

ERROR oslo_messaging.rpc.server Traceback (most recent call last):
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/server.py", line 157, in _process_incoming
ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 213, in dispatch
ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 183, in _do_dispatch
ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 169, in wrapped
ERROR oslo_messaging.rpc.server return f(self, *args, **kwargs)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/utils.py", line 520, in wrapper
ERROR oslo_messaging.rpc.server return func(self, *args, **kwargs)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 1596, in create_share_instance
ERROR oslo_messaging.rpc.server {'status': constants.STATUS_ERROR}
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
ERROR oslo_messaging.rpc.server self.force_reraise()
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
ERROR oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 1586, in create_share_instance
ERROR oslo_messaging.rpc.server share_group=share_group_ref,
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 518, in _provide_share_server_for_share
ERROR oslo_messaging.rpc.server return _wrapped_provide_share_server_for_share()
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py", line 271, in inner
ERROR oslo_messaging.rpc.server return f(*args, **kwargs)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 514, in _wrapped_provide_share_server_for_share
ERROR oslo_messaging.rpc.server metadata=metadata))
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 530, in _create_share_server_in_backend
ERROR oslo_messaging.rpc.server metadata=metadata)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 3235, in _setup_server
ERROR oslo_messaging.rpc.server self.driver.deallocate_network(context, share_server['id'])
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
ERROR oslo_messaging.rpc.server self.force_reraise()
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
ERROR oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/manager.py", line 3186, in _setup_server
ERROR oslo_messaging.rpc.server network_info, metadata=metadata)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/driver.py", line 891, in setup_server
ERROR oslo_messaging.rpc.server return self._setup_server(*args, **kwargs)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/drivers/generic.py", line 877, in _setup_server
ERROR oslo_messaging.rpc.server self.admin_context, network_info)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/drivers/service_instance.py", line 405, in set_up_service_instance
ERROR oslo_messaging.rpc.server context, instance_name, network_info)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/drivers/service_instance.py", line 498, in _create_service_instance
ERROR oslo_messaging.rpc.server service_image_id = self._get_service_image(context)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/share/drivers/service_instance.py", line 484, in _get_service_image
ERROR oslo_messaging.rpc.server images = [image.id for image in self.compute_api.image_list(context)
ERROR oslo_messaging.rpc.server File "/opt/stack/new/manila/manila/compute/nova.py", line 309, in image_list
ERROR oslo_messaging.rpc.server return novaclient(context).images.list()
ERROR oslo_messaging.rpc.server AttributeError: 'Client' object has no attribute 'images'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/469148

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/469148
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=5d5666b10e57a94bcde06c8a296002175d935c7b
Submitter: Jenkins
Branch: master

commit 5d5666b10e57a94bcde06c8a296002175d935c7b
Author: Valeriy Ponomaryov <email address hidden>
Date: Tue May 30 17:47:28 2017 +0300

    [Generic driver] Fix incompatibility with novaclient

    Novaclient has removed lots of proxies to other clients such as
    'images' [1], 'networks' [2] and 'security_groups' [3].
    So, fix incompatibilities the way we can work with old and
    new novaclient versions.

    [1] I2d9fd0243d42538bd1417a42357c17b09368d2a5
    [2] I8c520100a0016eed3959619c71dae037ebd72939
    [3] I6fa14f43d48f1e035ef54bd2d0078506f0c6d6e0

    Change-Id: Id7383329b2491f76579f042cbed06585c2214815
    Closes-Bug: #1691445

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/471390

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 5.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/471390
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=7b9a38f5a5571d7e177fb71bd6290fd5dcd31a9b
Submitter: Jenkins
Branch: stable/ocata

commit 7b9a38f5a5571d7e177fb71bd6290fd5dcd31a9b
Author: Valeriy Ponomaryov <email address hidden>
Date: Tue May 30 17:47:28 2017 +0300

    [Generic driver] Fix incompatibility with novaclient

    Novaclient has removed lots of proxies to other clients such as
    'images' [1], 'networks' [2] and 'security_groups' [3].
    So, fix incompatibilities the way we can work with old and
    new novaclient versions.

    [1] I2d9fd0243d42538bd1417a42357c17b09368d2a5
    [2] I8c520100a0016eed3959619c71dae037ebd72939
    [3] I6fa14f43d48f1e035ef54bd2d0078506f0c6d6e0

    Change-Id: Id7383329b2491f76579f042cbed06585c2214815
    Closes-Bug: #1691445
    (cherry picked from commit 5d5666b10e57a94bcde06c8a296002175d935c7b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 4.0.1 release.