host-assisted migration does not delete the source share from backend

Bug #1667450 reported by Rodrigo Barbieri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Rodrigo Barbieri

Bug Description

Since commit https://github.com/openstack/manila/commit/41813736718e2b81d1d907bf49feb1940c1e990f the host-assisted migration is not deleting the source share in the backend anymore, only from database.

It is doing so because it is now invoking the incorrect helper function. Should be calling migration.ShareMigrationHelper.delete_instance_and_wait instead of _migration_delete_instance.

Changed in manila:
importance: Undecided → High
assignee: nobody → Rodrigo Barbieri (rodrigo-barbieri2010)
description: updated
Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/437573
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=fae08f97f17b3dc6dfaa8df7679660707c518c3a
Submitter: Jenkins
Branch: master

commit fae08f97f17b3dc6dfaa8df7679660707c518c3a
Author: Rodrigo Barbieri <email address hidden>
Date: Thu Feb 23 16:34:05 2017 -0300

    Fix host-assisted migration stale source share

    Since change I88df15446ffe34f3f12770d53c3e03d232f495c2 the source
    share is not being deleted from backend anymore during
    migration_complete of a host-assisted migration.

    Fix this by invoking the correct helper function.

    Closes-bug: #1667450
    Change-Id: I0687fcf0eff0da04e67750421ff0cc97dd99276f

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 5.0.0.0b1

This issue was fixed in the openstack/manila 5.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.